x/sqlalchemy-migrate
Code Issues Proposed changes

fixes #107

Browse Source
This commit is contained in:
Domen Kožar
2011-02-05 14:25:25 +01:00
parent 09a8867edd
commit 1b37b76d2e
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
docs/changelog.rst
View File

@@ -22,9 +22,10 @@ Fixed bugs
to :mod:`migrate.exceptions` to :mod:`migrate.exceptions`
- cleared up test output and improved testing of deprecation warnings. - cleared up test output and improved testing of deprecation warnings.
- some documentation fixes - some documentation fixes
- fixed bug with column dropping in sqlite (issue 96) - #107: fixed syntax error in genmodel.py
- #96: fixed bug with column dropping in sqlite
- #94: fixed bug that prevented non-unique indexes being created
- fixed bug with column dropping involving foreign keys - fixed bug with column dropping involving foreign keys
- fixed bug that prevented non-unique indexes being created (issue 94)
- fixed bug when dropping columns with unique constraints in sqlite - fixed bug when dropping columns with unique constraints in sqlite
- rewrite of the schema diff internals, now supporting column - rewrite of the schema diff internals, now supporting column
differences in additon to missing columns and tables. differences in additon to missing columns and tables.

8
migrate/versioning/genmodel.py
View File

@@ -170,11 +170,11 @@ class ModelGenerator(object):
modelTable, col.name)) modelTable, col.name))
for modelCol, databaseCol, modelDecl, databaseDecl in diffDecl: for modelCol, databaseCol, modelDecl, databaseDecl in diffDecl:
upgradeCommands.append( upgradeCommands.append(
'assert False, "Can\'t alter columns: %s:%s=>%s"', 'assert False, "Can\'t alter columns: %s:%s=>%s"' % (
modelTable, modelCol.name, databaseCol.name) modelTable, modelCol.name, databaseCol.name))
downgradeCommands.append( downgradeCommands.append(
'assert False, "Can\'t alter columns: %s:%s=>%s"', 'assert False, "Can\'t alter columns: %s:%s=>%s"' % (
modelTable, modelCol.name, databaseCol.name) modelTable, modelCol.name, databaseCol.name))
pre_command = ' meta.bind = migrate_engine' pre_command = ' meta.bind = migrate_engine'
return ( return (