Add support for module aliases, step #1

It adds support for module aliases in the mls processing.
Additionally, it adds alias 'savanna' for 'sahara' module.

Change-Id: Ifb02910956a7c1a8937063af9eb9e48031f06ee4
This commit is contained in:
Sergey Lukjanov
2014-03-14 15:20:47 +04:00
parent 1f0c66834f
commit 3c9bed12b3
5 changed files with 50 additions and 17 deletions

View File

@@ -6328,6 +6328,9 @@
}, },
{ {
"module": "sahara", "module": "sahara",
"aliases": [
"savanna"
],
"uri": "git://github.com/openstack/sahara.git", "uri": "git://github.com/openstack/sahara.git",
"organization": "openstack", "organization": "openstack",
"releases": [ "releases": [

View File

@@ -100,6 +100,12 @@
}, },
"required": ["tag_from", "tag_to", "release_name"] "required": ["tag_from", "tag_to", "release_name"]
} }
},
"aliases": {
"type": "array",
"items": {
"type": "string"
}
} }
}, },
"required": ["uri", "module", "organization"], "required": ["uri", "module", "organization"],
@@ -203,4 +209,4 @@
} }
} }
} }
} }

View File

@@ -183,4 +183,4 @@
} }
] ]
} }

View File

@@ -37,6 +37,7 @@ class RecordProcessor(object):
self.releases_dates = [r['end_date'] for r in self.releases] self.releases_dates = [r['end_date'] for r in self.releases]
self.modules = None self.modules = None
self.alias_module_map = None
def _get_release(self, timestamp): def _get_release(self, timestamp):
release_index = bisect.bisect(self.releases_dates, timestamp) release_index = bisect.bisect(self.releases_dates, timestamp)
@@ -45,20 +46,28 @@ class RecordProcessor(object):
def _get_modules(self): def _get_modules(self):
if self.modules is None: if self.modules is None:
self.modules = set() self.modules = set()
self.alias_module_map = dict()
for repo in utils.load_repos(self.runtime_storage_inst): for repo in utils.load_repos(self.runtime_storage_inst):
module = repo['module'].lower() module = repo['module'].lower()
add = True module_aliases = filter(str.lower, repo.get('aliases') or [])
for m in self.modules:
if module.find(m) >= 0:
add = False
break
if m.find(module) >= 0:
self.modules.remove(m)
break
if add:
self.modules.add(module)
return self.modules add = True
for module_name in ([module] + module_aliases):
for m in self.modules:
if module_name.find(m) >= 0:
add = False
break
if m.find(module_name) >= 0:
self.modules.remove(m)
break
if add:
self.modules.add(module_name)
for alias in module_aliases:
self.alias_module_map[alias] = module
return self.modules, self.alias_module_map
def _find_company(self, companies, date): def _find_company(self, companies, date):
for r in companies: for r in companies:
@@ -328,7 +337,8 @@ class RecordProcessor(object):
pos = len(subject) pos = len(subject)
best_guess_module = None best_guess_module = None
for module in self._get_modules(): modules, alias_module_map = self._get_modules()
for module in modules:
find = subject.find(module) find = subject.find(module)
if (find >= 0) and (find < pos): if (find >= 0) and (find < pos):
pos = find pos = find
@@ -341,6 +351,8 @@ class RecordProcessor(object):
if not record.get('module'): if not record.get('module'):
record['module'] = 'unknown' record['module'] = 'unknown'
elif record['module'] in alias_module_map:
record['module'] = alias_module_map[record['module']]
def _process_email(self, record): def _process_email(self, record):
record['primary_key'] = record['message_id'] record['primary_key'] = record['message_id']

View File

@@ -1138,9 +1138,21 @@ class TestRecordProcessor(testtools.TestCase):
with mock.patch('stackalytics.processor.utils.load_repos') as patch: with mock.patch('stackalytics.processor.utils.load_repos') as patch:
patch.return_value = [{'module': 'nova'}, patch.return_value = [{'module': 'nova'},
{'module': 'python-novaclient'}, {'module': 'python-novaclient'},
{'module': 'neutron'}] {'module': 'neutron'},
modules = record_processor_inst._get_modules() {'module': 'sahara', 'aliases': ['savanna']}]
self.assertEqual(set(['nova', 'neutron']), set(modules)) modules, module_alias_map = record_processor_inst._get_modules()
self.assertEqual(set(['nova', 'neutron', 'sahara', 'savanna']),
set(modules))
self.assertEqual({'savanna': 'sahara'}, module_alias_map)
def test_guess_module(self):
record_processor_inst = self.make_record_processor()
with mock.patch('stackalytics.processor.utils.load_repos') as patch:
patch.return_value = [{'module': 'sahara', 'aliases': ['savanna']}]
record = {'subject': '[savanna] T'}
record_processor_inst._guess_module(record)
self.assertEqual({'subject': '[savanna] T', 'module': 'sahara'},
record)
def assertRecordsMatch(self, expected, actual): def assertRecordsMatch(self, expected, actual):
for key, value in six.iteritems(expected): for key, value in six.iteritems(expected):