x/stackalytics
Code Issues Proposed changes

Fix error of open reviews report

Browse Source 
The issue happend when there were no reviews waiting for reviewers

Closes bug 1394784

Change-Id: I639ce0dfc49eb50c6a5dc84440391f92d2b6c39c
This commit is contained in:
Ilya Shakhat
2014-12-26 14:23:39 +03:00
parent 801a91face
commit 3f3d6eebe2
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
stackalytics/dashboard/templates/reports/open_reviews.html
View File

@@ -1,7 +1,7 @@
{% extends "reports/base_report.html" %} {% extends "reports/base_report.html" %}
{% block title %} {% block title %}
Open reviews report for {{ module }} Open change requests report for {{ module }}
{% endblock %} {% endblock %}
{% block scripts %} {% block scripts %}
@@ -14,7 +14,7 @@ Open reviews report for {{ module }}
{% endblock %} {% endblock %}
{% block content %} {% block content %}
<h1>Open reviews for {{ module }}</h1> <h1>Open change requests for {{ module }}</h1>
<h3>Summary</h3> <h3>Summary</h3>
<ul> <ul>
@@ -23,8 +23,8 @@ Open reviews report for {{ module }}
<li>Waiting on reviewer: {{ waiting_on_reviewer }}</li> <li>Waiting on reviewer: {{ waiting_on_reviewer }}</li>
</ul> </ul>
{% if total_open %} {% if waiting_on_reviewer %}
<h3>Stats since last revision</h3> <h3>Change requests waiting for reviewers since the last vote or mark</h3>
<ul> <ul>
<li>Average wait time: {{ latest_revision.average }}</li> <li>Average wait time: {{ latest_revision.average }}</li>
@@ -39,7 +39,7 @@ Open reviews report for {{ module }}
{% endfor %} {% endfor %}
</ol> </ol>
<h3>Stats since first revision</h3> <h3>Change requests waiting for reviewers since the creation date</h3>
<ul> <ul>
<li>Average wait time: {{ first_revision.average }}</li> <li>Average wait time: {{ first_revision.average }}</li>
@@ -54,5 +54,7 @@ Open reviews report for {{ module }}
{% endfor %} {% endfor %}
</ol> </ol>
{% else %}
<h3>No change requests waiting for reviewers</h3>
{% endif %} {% endif %}
{% endblock %} {% endblock %}