x/stackalytics
Code Issues Proposed changes

Enabled hacking check H404

Browse Source 
* [H404] Multi line docstrings should start without a leading new line.

Change-Id: I4754c98640c71e73fe99b864bd37a23f92377430
This commit is contained in:
Christian Berendt 2014-07-11 15:17:28 +02:00
parent ea38394160
commit 5c971ae6cb
3 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
stackalytics/processor/driverlog.py
View File

@ -22,9 +22,7 @@ LOG = logging.getLogger(__name__)
def _find_vote(review, ci_id, patch_set_number): def _find_vote(review, ci_id, patch_set_number):
""" """Finds vote corresponding to ci_id."""
Finds vote corresponding to ci_id
"""
for patch_set in review['patchSets']: for patch_set in review['patchSets']:
if patch_set['number'] == patch_set_number: if patch_set['number'] == patch_set_number:
for approval in (patch_set.get('approvals') or []): for approval in (patch_set.get('approvals') or []):
@ -38,9 +36,7 @@ def _find_vote(review, ci_id, patch_set_number):
def find_ci_result(review, ci_map): def find_ci_result(review, ci_map):
""" """For a given stream of reviews yields results produced by CIs."""
For a given stream of reviews yields results produced by CIs
"""
review_id = review['id'] review_id = review['id']
review_number = review['number'] review_number = review['number']

5
stackalytics/processor/record_processor.py
View File

@ -326,8 +326,9 @@ class RecordProcessor(object):
return mark return mark
def _process_review(self, record): def _process_review(self, record):
""" """Process a review.
Process a review. Review spawns into records of three types:
Review spawns into records of three types:
* review - records that a user created review request * review - records that a user created review request
* patch - records that a user submitted another patch set * patch - records that a user submitted another patch set
* mark - records that a user set approval mark to given review * mark - records that a user set approval mark to given review

3
tox.ini
View File

@ -53,8 +53,7 @@ commands = python setup.py build_sphinx
[flake8] [flake8]
# E125 continuation line does not distinguish itself from next logical line # E125 continuation line does not distinguish itself from next logical line
# H404 multi line docstring should start with a summary ignore = E125
ignore = E125,H404
show-source = true show-source = true
builtins = _ builtins = _
exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,tools,build exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,tools,build