x/stackalytics
Code Issues Proposed changes

Do not re-index items in KPI report scripts

Browse Source 
Use index returned ny Stackalytics API instead of re-indexing
items. Also remove unused filtering code that prevents implementation
from being simple.

Change-Id: Ifc2451d24134d1c05aa45165b2571bbc151c198f
This commit is contained in:
Ilya Shakhat
2015-07-31 18:49:31 +03:00
parent c563296c17
commit 70c6fe1d63
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
stackalytics/dashboard/static/js/stackalytics-kpi.js
View File

@@ -32,24 +32,18 @@ function appendKpiBlock(container_id, kpi_block) {
} }
} }
function processStats(container_id, url, query_options, item_id, metric, text_goal, comparator, data_filter) { function processStats(container_id, url, query_options, item_id, metric, text_goal, comparator) {
$.ajax({ $.ajax({
url: makeURI(url, query_options), url: makeURI(url, query_options),
dataType: "jsonp", dataType: "jsonp",
success: function (data) { success: function (data) {
data = data["stats"]; data = data["stats"];
var position = -1; var position = -1;
var index = 0;
var sum = 0; var sum = 0;
for (var i = 0; i < data.length; i++) { for (var i = 0; i < data.length; i++) {
if (data_filter) {
if (!data_filter(data[i])) {
continue;
}
}
sum += data[i][metric]; sum += data[i][metric];
data[i].index = ++index; // re-index data[i].index = data[i]["index"];
if (data[i].id == item_id) { if (data[i].id == item_id) {
position = i; position = i;
} }
@@ -73,7 +67,7 @@ function processStats(container_id, url, query_options, item_id, metric, text_go
}); });
} }
function goalPositionInTop(container_id, query_options, item_type, item_id, position, text_goal, data_filter) { function goalPositionInTop(container_id, query_options, item_type, item_id, position, text_goal) {
$(document).ready(function () { $(document).ready(function () {
processStats(container_id, "/api/1.0/stats/" + item_type, query_options, item_id, "metric", text_goal, processStats(container_id, "/api/1.0/stats/" + item_type, query_options, item_id, "metric", text_goal,
function (item, sum) { function (item, sum) {
@@ -84,7 +78,7 @@ function goalPositionInTop(container_id, query_options, item_type, item_id, posi
"Position " + item.index + " is worse than the goal position " + position, "Position " + item.index + " is worse than the goal position " + position,
value: item.index value: item.index
} }
}, data_filter); });
}); });
} }