diff --git a/dashboard/reports.py b/dashboard/reports.py
index c301c417e..99890a930 100644
--- a/dashboard/reports.py
+++ b/dashboard/reports.py
@@ -170,21 +170,16 @@ def _get_punch_card_data(records):
def _get_activity_summary(record_ids):
memory_storage_inst = vault.get_memory_storage()
- types = ['mark', 'patch', 'email', 'bpd', 'bpc', 'commit']
+ types = ['mark', 'patch', 'email', 'bpd', 'bpc']
record_ids_by_type = set()
for t in types:
record_ids_by_type |= memory_storage_inst.get_record_ids_by_type(t)
record_ids &= record_ids_by_type
- contribution_summary = helpers.get_contribution_summary(
- memory_storage_inst.get_records(record_ids))
-
- record_ids -= memory_storage_inst.get_record_ids_by_type('commit')
punch_card_data = _get_punch_card_data(
memory_storage_inst.get_records(record_ids))
return {
- 'contribution': contribution_summary,
'punch_card_data': punch_card_data,
}
diff --git a/dashboard/templates/_macros/contribution_summary.html b/dashboard/templates/_macros/contribution_summary.html
new file mode 100644
index 000000000..f1bd3239c
--- /dev/null
+++ b/dashboard/templates/_macros/contribution_summary.html
@@ -0,0 +1,44 @@
+{% macro show_contribution_summary(user_id=None, company=None, show_all=True) -%}
+
+
+
+
+
+
Contribution Summary
+
+
+{%- endmacro %}
diff --git a/dashboard/templates/overview.html b/dashboard/templates/overview.html
index e535c08a8..af77af705 100644
--- a/dashboard/templates/overview.html
+++ b/dashboard/templates/overview.html
@@ -1,5 +1,6 @@
{% extends "layout.html" %}
{% import '_macros/activity_log.html' as activity_log %}
+{% import '_macros/contribution_summary.html' as contribution_summary %}
{% set show_company_breakdown = (not company) and (not user_id) %}
{% set show_engineer_breakdown = (not user_id) %}
@@ -10,11 +11,24 @@
{% set show_activity = (show_user_activity) or (show_module_activity) %}
{% set show_user_contribution = (user_id) or (company) %}
{% set show_module_contribution = (module) and (not user_id) %}
-{% set show_contribution = (show_user_contribution) or (show_module_contribution) %}
{% set show_user_profile = (user_id) %}
{% set show_top_mentors_options = (metric == 'tm_marks') %}
{% set show_review_ratio = (metric in ['marks', 'tm_marks']) %}
+{% macro show_report_links(module=None, company=None, user_id=None) -%}
+ {% if module %}
+
+
+
+ {% endif %}
+ {% if company %}
+
+ {% endif %}
+ {% if user_id %}
+
+ {% endif %}
+{%- endmacro %}
+
{% block scripts %}
{# Templates #}
@@ -83,29 +86,6 @@
{% endraw %}
-
-
{% endblock %}
{% block report_options %}
@@ -202,7 +182,8 @@
{% endif %}
{% if show_module_contribution %}
-
+ {{ contribution_summary.show_contribution_summary(show_all=False) }}
+ {{ show_report_links(module, company, user_id) }}
{% endif %}
{% endblock %}
@@ -258,7 +239,8 @@
{% endif %}
{% if show_user_contribution %}
-
+ {{ contribution_summary.show_contribution_summary(show_all=False) }}
+ {{ show_report_links(module, company, user_id) }}
{% endif %}
{% if show_module_activity %}
diff --git a/dashboard/templates/reports/base_report.html b/dashboard/templates/reports/base_report.html
index b2d7faee5..186caef60 100644
--- a/dashboard/templates/reports/base_report.html
+++ b/dashboard/templates/reports/base_report.html
@@ -40,21 +40,6 @@
{% block scripts %}{% endblock %}
{% endblock %}
-{% macro show_contribution_summary(contribution) -%}
-
- Contribution summary
-
- - Total commits: {{ contribution.commit_count }}
- - Total LOC: {{ contribution.loc }}
- - Review stat (-2, -1, +1, +2): {{ contribution.marks[-2] }}, {{ contribution.marks[-1] }},
- {{ contribution.marks[1] }}, {{ contribution.marks[2] }}
- - Draft Blueprints: {{ contribution.drafted_blueprint_count }}
- - Completed Blueprints: {{ contribution.completed_blueprint_count }}
- - Emails: {{ contribution.email_count }}
-
-
-{%- endmacro %}
-
{% block body %}
diff --git a/dashboard/templates/reports/company_activity.html b/dashboard/templates/reports/company_activity.html
index 1f9249819..0183795c6 100644
--- a/dashboard/templates/reports/company_activity.html
+++ b/dashboard/templates/reports/company_activity.html
@@ -1,5 +1,6 @@
{% extends "reports/base_report.html" %}
{% import '_macros/activity_log.html' as activity_log %}
+{% import '_macros/contribution_summary.html' as contribution_summary %}
{% block title %}
{{ company_name }} activity in OpenStack
@@ -16,7 +17,7 @@
{% block content %}
{{ company_name }} activity report
-{{ show_contribution_summary(contribution) }}
+{{ contribution_summary.show_contribution_summary(company=company_name) }}
diff --git a/dashboard/templates/reports/user_activity.html b/dashboard/templates/reports/user_activity.html
index d4390db6b..b117376b7 100644
--- a/dashboard/templates/reports/user_activity.html
+++ b/dashboard/templates/reports/user_activity.html
@@ -1,5 +1,6 @@
{% extends "reports/base_report.html" %}
{% import '_macros/activity_log.html' as activity_log %}
+{% import '_macros/contribution_summary.html' as contribution_summary %}
{% block title %}
{{ user.user_name }} activity in OpenStack
@@ -30,7 +31,7 @@
{% endif %}
-{{ show_contribution_summary(contribution) }}
+{{ contribution_summary.show_contribution_summary(user_id=user.user_id) }}