x/stackalytics
Code Issues Proposed changes

Remove unused ldap_id

Browse Source 
ldap_id is not used at any places and default_data.json doesn't
contain it for user information. So let's remove it for the cleanup.

Change-Id: Ic4a27a6bd882ae6fd700a85c0661c2b2407bad88
This commit is contained in:
Ken'ichi Ohmichi
2017-06-13 13:54:10 -07:00
parent bc34e01d29
commit 8eaad691a7
5 changed files with 4 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
stackalytics/tests/unit/test_config_files.py
View File

@@ -125,8 +125,7 @@ class TestConfigFiles(testtools.TestCase):
def _verify_users_in_alphabetical_order(self, file_name):
users = self._read_file(file_name)['users']
self._verify_ordering(
users, key=lambda x: (x.get('launchpad_id') or x.get('ldap_id') or
x.get('github_id')),
users, key=lambda x: (x.get('launchpad_id') or x.get('github_id')),
msg='List of users should be ordered by launchpad id or ldap id '
'or github id')