x/stackalytics
Code Issues Proposed changes

Replace urlparse with py3kcompat.urlutils

Browse Source 
Replace urlparse.* with py3kcompat.urlutils.* to make
code Python 3 compatible.

Part of blueprint py33

Change-Id: Ie4c9c6f3b4d7ebfb03428edac1f8222ec1e7506b
This commit is contained in:
Eric Guo
2014-01-15 20:08:04 +08:00
parent 400f2e7b60
commit 9cc610f600
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
stackalytics/processor/launchpad_utils.py
View File

@@ -14,9 +14,9 @@
# limitations under the License. # limitations under the License.
import httplib import httplib
import urlparse
from stackalytics.openstack.common import log as logging from stackalytics.openstack.common import log as logging
from stackalytics.openstack.common.py3kcompat import urlutils
from stackalytics.processor import utils from stackalytics.processor import utils
@@ -41,7 +41,7 @@ def lp_profile_by_email(email):
def lp_module_exists(module): def lp_module_exists(module):
uri = LP_URI_DEVEL % module uri = LP_URI_DEVEL % module
parsed_uri = urlparse.urlparse(uri) parsed_uri = urlutils.urlparse(uri)
conn = httplib.HTTPConnection(parsed_uri.netloc) conn = httplib.HTTPConnection(parsed_uri.netloc)
conn.request('GET', parsed_uri.path) conn.request('GET', parsed_uri.path)
res = conn.getresponse() res = conn.getresponse()

6
stackalytics/processor/mls.py
View File

@@ -18,11 +18,11 @@ import gzip
import httplib import httplib
import re import re
import StringIO import StringIO
import urlparse
import six import six
from stackalytics.openstack.common import log as logging from stackalytics.openstack.common import log as logging
from stackalytics.openstack.common.py3kcompat import urlutils
from stackalytics.processor import utils from stackalytics.processor import utils
@@ -59,12 +59,12 @@ def _get_mail_archive_links(uri):
content = utils.read_uri(uri) content = utils.read_uri(uri)
links = set(re.findall(r'\shref\s*=\s*[\'"]([^\'"]*\.txt\.gz)', content, links = set(re.findall(r'\shref\s*=\s*[\'"]([^\'"]*\.txt\.gz)', content,
flags=re.IGNORECASE)) flags=re.IGNORECASE))
return [urlparse.urljoin(uri, link) for link in links] return [urlutils.urljoin(uri, link) for link in links]
def _link_content_changed(link, runtime_storage_inst): def _link_content_changed(link, runtime_storage_inst):
LOG.debug('Check changes for mail archive located at uri: %s', link) LOG.debug('Check changes for mail archive located at uri: %s', link)
parsed_uri = urlparse.urlparse(link) parsed_uri = urlutils.urlparse(link)
conn = httplib.HTTPConnection(parsed_uri.netloc) conn = httplib.HTTPConnection(parsed_uri.netloc)
conn.request('HEAD', parsed_uri.path) conn.request('HEAD', parsed_uri.path)
res = conn.getresponse() res = conn.getresponse()