x/stackalytics
Code Issues Proposed changes

Expect new types of approval records from Gerrit

Browse Source 
In Gerrit 2.8 approval types were changed from:
 CRVW became 'Code-Review'
 VRIF became 'Verifyied'
 APRV became 'Approved'

Note: Upgrade-Impact on reviews

Change-Id: I6a2cd64ace41cf1e65d4777aa249f286fe848a8a
This commit is contained in:
Ilya Shakhat
2014-04-30 15:58:51 +04:00
parent 15800b759e
commit a68a104695
7 changed files with 18 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
stackalytics/processor/record_processor.py
View File

@@ -322,10 +322,6 @@ class RecordProcessor(object):
mark['review_id'] = review['id']
mark['patch'] = int(patch['number'])
# map type from new Gerrit to old
mark['type'] = {'Approved': 'APRV', 'Code-Review': 'CRVW',
'Verified': 'VRIF'}.get(mark['type'], mark['type'])
self._update_record_and_user(mark)
return mark
@@ -353,7 +349,7 @@ class RecordProcessor(object):
continue # not reviewed by anyone
for approval in patch['approvals']:
if approval['type'] not in ('CRVW', 'APRV'):
if approval['type'] not in ('Code-Review', 'Approved'):
continue # keep only Code-Review and Approved
if ('email' not in approval['by'] or
'username' not in approval['by']):
@@ -681,7 +677,8 @@ class RecordProcessor(object):
lambda: {'patch_number': 0, 'marks': []})
for record in self.runtime_storage_inst.get_all_records():
if record['record_type'] == 'mark' and record['type'] == 'CRVW':
if ((record['record_type'] == 'mark') and
(record['type'] == 'Code-Review')):
review_id = record['review_id']
patch_number = record['patch']