x/stackalytics
Code Issues Proposed changes

Merge "Fixed module filtering in 'modules' drop-down"

Browse Source
This commit is contained in:
Jenkins
2014-05-19 11:44:29 +00:00
committed by Gerrit Code Review
parent bbe1d302b6 a468e05277
commit ca37098d93
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
dashboard/web.py
View File

@@ -294,7 +294,7 @@ def get_modules_json(record_ids, query_filter, **kwargs):
add_modules = set([]) add_modules = set([])
for module in six.itervalues(module_id_index): for module in six.itervalues(module_id_index):
if set(module['modules']) <= module_ids: if set(module['modules']) & module_ids:
add_modules.add(module['id']) add_modules.add(module['id'])
module_ids |= add_modules module_ids |= add_modules

3
tests/api/test_modules.py
View File

@@ -61,7 +61,8 @@ class TestAPIModules(test_api.TestAPI):
modules = json.loads(response.data)['modules'] modules = json.loads(response.data)['modules']
self.assertEqual( self.assertEqual(
[{'id': 'glance', 'text': 'glance', 'tag': 'module'}, [{'id': 'glance', 'text': 'glance', 'tag': 'module'},
{'id': 'nova', 'text': 'nova', 'tag': 'module'}], {'id': 'nova', 'text': 'nova', 'tag': 'module'},
{'id': 'nova-group', 'text': 'nova-group', 'tag': 'group'}],
modules, modules,
message='Expected modules belonging to project type plus ' message='Expected modules belonging to project type plus '
'module groups that are completely within ' 'module groups that are completely within '