x/stackalytics
Code Issues Proposed changes

Added handling of key erorrs

Browse Source 
Change-Id: Ic06725f3be524a553d4701c8019eb1a1741fe408
This commit is contained in:
Sergey Nikitin
2020-12-27 09:44:43 +04:00
parent 28443ccbe1
commit d80b712f59
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
stackalytics/processor/record_processor.py
View File

@@ -291,7 +291,7 @@ class RecordProcessor(object):
mark['patch'] = int(patch['number']) mark['patch'] = int(patch['number'])
mark['gerrit_hostname'] = review['gerrit_hostname'] mark['gerrit_hostname'] = review['gerrit_hostname']
if reviewer['username'] == patch['uploader'].get('username'): if reviewer['username'] == patch.get('uploader', {}).get('username'):
# reviewer is the same as author of the patch # reviewer is the same as author of the patch
mark['type'] = 'Self-%s' % mark['type'] mark['type'] = 'Self-%s' % mark['type']
@@ -307,6 +307,9 @@ class RecordProcessor(object):
* mark - records that a user set approval mark to given review * mark - records that a user set approval mark to given review
""" """
owner = record.get('owner', {}) owner = record.get('owner', {})
if 'owner' not in record:
LOG.info('Record has no owner. %s' % record)
if 'email' in owner or 'username' in owner: if 'email' in owner or 'username' in owner:
yield self._make_review_record(record) yield self._make_review_record(record)
@@ -510,9 +513,13 @@ class RecordProcessor(object):
} }
for record in record_iterator: for record in record_iterator:
try:
for r in PROCESSORS[record['record_type']](record): for r in PROCESSORS[record['record_type']](record):
self._renew_record_date(r) self._renew_record_date(r)
yield r yield r
except KeyError as e:
LOG.error("Could not process record %s because "
"of key error %s" % (record, e))
def _update_records_with_releases(self, release_index): def _update_records_with_releases(self, release_index):
LOG.info('Update records with releases') LOG.info('Update records with releases')