x/stackalytics
Code Issues Proposed changes

Return 404 if Open Reviews report is asked for non-existent module

Browse Source 
Change-Id: Idafa1da3f1ab7fbd8927ab9282340841cd56b935
This commit is contained in:
Ilya Shakhat
2014-09-30 18:49:35 +04:00
parent b848c74386
commit dd68085834
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
stackalytics/dashboard/reports.py
View File

@@ -92,10 +92,10 @@ def open_reviews(module):
module_id_index = vault.get_vault()['module_id_index'] module_id_index = vault.get_vault()['module_id_index']
module = module.lower() module = module.lower()
if module in module_id_index: if module not in module_id_index:
modules = module_id_index[module]['modules'] flask.abort(404)
else:
modules = [module] modules = module_id_index[module]['modules']
review_ids = (memory_storage_inst.get_record_ids_by_modules(modules) & review_ids = (memory_storage_inst.get_record_ids_by_modules(modules) &
memory_storage_inst.get_record_ids_by_types(['review'])) memory_storage_inst.get_record_ids_by_types(['review']))