x/stackalytics
Code Issues Proposed changes

Modify use of assertTrue(A in B)

Browse Source 
Developers should use assertIn(A, B) instead of assertTrue(A in B ).
Developers should use assertNotIn(A, B) instead of assertFalse(A in B ).

TrivialFix

Change-Id: Icecdace82ea6229af2bddfb65b33ecb9d8c05a3c
This commit is contained in:
melissaml
2016-10-08 11:46:52 +08:00
parent 9fd9b8fe87
commit f3acbf3485
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
stackalytics/tests/unit/test_record_processor.py
View File

@@ -1211,8 +1211,8 @@ class TestRecordProcessor(testtools.TestCase):
self.assertEqual(0, bp2['mention_date']) self.assertEqual(0, bp2['mention_date'])
email = runtime_storage_inst.get_by_primary_key('<another-message-id>') email = runtime_storage_inst.get_by_primary_key('<another-message-id>')
self.assertTrue('mod:blueprint' in email['blueprint_id']) self.assertIn('mod:blueprint', email['blueprint_id'])
self.assertFalse('mod:invalid' in email['blueprint_id']) self.assertNotIn('mod:invalid', email['blueprint_id'])
def test_mark_disagreement(self): def test_mark_disagreement(self):
record_processor_inst = self.make_record_processor( record_processor_inst = self.make_record_processor(