From a2ba511da391b87512f1d177304c445fccf8b5a0 Mon Sep 17 00:00:00 2001 From: Lisa Zangrando Date: Thu, 11 May 2017 12:22:53 +0200 Subject: [PATCH] manager.notify() doesn't handle the NotImplementedError exceptions In case a manager doesn't implement the method doOnEvent() the NotImplementedError exception is raised. The manager.notify() doesn't handle such exceptions and fails. This fix solves the problem. Bug: #1690117 Change-Id: I005658c4341106b54f6757ee4dfcca08a2405605 Sem-Ver: bugfix --- synergy/common/manager.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/synergy/common/manager.py b/synergy/common/manager.py index 79c515c..27f2609 100644 --- a/synergy/common/manager.py +++ b/synergy/common/manager.py @@ -59,8 +59,11 @@ class Manager(SynergyObject, Thread): *args, **kargs) else: for manager in self.managers.values(): - if manager.getName() != manager_name: - manager.doOnEvent(event_type, *args, **kargs) + if manager.getName() != self.getName(): + try: + manager.doOnEvent(event_type, *args, **kargs) + except NotImplementedError: + pass def getOptions(self): return self.config_opts