Update patch set 2

Patch Set 2: (4 comments) Hi Lisa, here are some questions about the changes. I also added a "Depends-On" in the commit message to make sure this commit is not merged before the corresponding commit for the scheduler. I will do some testing for systemd restart behaviour and post them here. Patch-set: 2 Label: Verified=0
2017-02-13 15:29:05 +00:00 · 2017-02-13 15:29:05 +00:00 · bf5acf9032
parent aa794909d5
commit bf5acf9032
1 changed files with 96 additions and 0 deletions
--- a/96
+++ b/96
@ -0,0 +1,96 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "fa31d9ce_1a055ebb",
+        "filename": "packaging/debian/python-synergy-service.synergy.upstart",
+        "patchSetId": 2
+      },
+      "lineNbr": 19,
+      "author": {
+        "id": 20409
+      },
+      "writtenOn": "2017-02-13T15:29:05Z",
+      "side": 1,
+      "message": "As mentioned during this morning meeting, Ubuntu 16.04 comes with systemd instead of upstart to manage services.\nIf you agree, I will remove the upstart script in a separate commit and in this present commit we should just leave the file as it was before.",
+      "range": {
+        "startLine": 1,
+        "startChar": 0,
+        "endLine": 19,
+        "endChar": 10
+      },
+      "revId": "5dd26030af5d547a54eb68d3c7ba42a40ca25e2e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "fa31d9ce_25003eaa",
+        "filename": "packaging/rpm/python-synergy.spec",
+        "patchSetId": 2
+      },
+      "lineNbr": 80,
+      "author": {
+        "id": 20409
+      },
+      "writtenOn": "2017-02-13T15:29:05Z",
+      "side": 1,
+      "message": "If I understand correctly, what is under \"%post\" is what will be run after a package is first installed, it doesn\u0027t affect package upgrade.\n\nShould we not start synergy after the first install?\nIf not, I\u0027d rather remove the \"%post\" code block entirely.",
+      "range": {
+        "startLine": 80,
+        "startChar": 0,
+        "endLine": 80,
+        "endChar": 30
+      },
+      "revId": "5dd26030af5d547a54eb68d3c7ba42a40ca25e2e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "fa31d9ce_05c6da47",
+        "filename": "packaging/rpm/python-synergy.spec",
+        "patchSetId": 2
+      },
+      "lineNbr": 88,
+      "author": {
+        "id": 20409
+      },
+      "writtenOn": "2017-02-13T15:29:05Z",
+      "side": 1,
+      "message": "If I understand the doc/code [1] correclty, this line should be removed as it will cause synergy to restart after the package is upgraded.\n\n[1] https://github.com/systemd/systemd/blob/3b07d037f316196f05cc3d2d2812a3e8401a4c06/src/core/macros.systemd.in#L74-L79",
+      "range": {
+        "startLine": 88,
+        "startChar": 0,
+        "endLine": 88,
+        "endChar": 44
+      },
+      "revId": "5dd26030af5d547a54eb68d3c7ba42a40ca25e2e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "fa31d9ce_dccae36d",
+        "filename": "scripts/synergy.service",
+        "patchSetId": 2
+      },
+      "lineNbr": 9,
+      "author": {
+        "id": 20409
+      },
+      "writtenOn": "2017-02-13T15:29:05Z",
+      "side": 1,
+      "message": "I don\u0027t see any option \"--config-dir\" in the current Synergy code. Is it handled correctly?\n\nAlso in synergy/service.py:426-427 there is\n\n        config.parseArgs(args\u003dsys.argv[1:],\n                         default_config_files\u003d[\"/etc/synergy/synergy.conf\"])\n\ndo this needs to be changed?",
+      "range": {
+        "startLine": 9,
+        "startChar": 10,
+        "endLine": 9,
+        "endChar": 61
+      },
+      "revId": "5dd26030af5d547a54eb68d3c7ba42a40ca25e2e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}