Update patch set 2

Patch Set 2: Code-Review+1

(1 comment)

Very good, explanation of the configuration variables is really nice to have.

See just one comment about the notification topic.

Patch-set: 2
Reviewer: Gerrit User 20409 <20409@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
This commit is contained in:
Gerrit User 20409 2017-01-30 13:00:08 +00:00 committed by Gerrit Code Review
parent 2fdbc13ec5
commit efbf7c4e65
1 changed files with 27 additions and 0 deletions

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "3a461143_7a0b852a",
"filename": "config/synergy.conf",
"patchSetId": 2
},
"lineNbr": 71,
"author": {
"id": 20409
},
"writtenOn": "2017-01-30T13:00:08Z",
"side": 1,
"message": "Is this related and does this affect the \"topic\" variable that we must change before installing Synergy?\n\nThis refers to the following in the documentation:\n\n\u003e The second one is edit /usr/lib/python2.7/site-packages/nova/cmd/conductor.py (for CentOS) / /usr/lib/python2.7/site-packages/nova/cmd/conductor.py (for Ubuntu) replacing:\n\u003e \n\u003e topic\u003dCONF.conductor.topic,\n\u003e \n\u003e with:\n\u003e \n\u003e topic\u003dCONF.conductor.topic + \"_synergy\",",
"range": {
"startLine": 67,
"startChar": 0,
"endLine": 71,
"endChar": 34
},
"revId": "1708739fd5e34bc7d84459539891e608203fa0b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}