x/tobiko
Code Issues Proposed changes

Merge "Use a property to get undercloud key_filename SSH parameter"

Browse Source
This commit is contained in:
Zuul
2022-07-25 15:00:30 +00:00
committed by Gerrit Code Review
parent 2b6e853269 49b18274e1
commit 2582ba3876
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tobiko/tripleo/_undercloud.py
View File

@@ -157,16 +157,14 @@ class UndecloudHostConfig(tobiko.SharedFixture):
def __init__(self, **kwargs): def __init__(self, **kwargs):
super(UndecloudHostConfig, self).__init__() super(UndecloudHostConfig, self).__init__()
self._connect_parameters = ssh.gather_ssh_connect_parameters(**kwargs) self._connect_parameters = ssh.gather_ssh_connect_parameters(**kwargs)
self.key_filename: typing.List[str] = []
def setup_fixture(self): def setup_fixture(self):
self.hostname = CONF.tobiko.tripleo.undercloud_ssh_hostname.strip() self.hostname = CONF.tobiko.tripleo.undercloud_ssh_hostname.strip()
self.port = CONF.tobiko.tripleo.undercloud_ssh_port self.port = CONF.tobiko.tripleo.undercloud_ssh_port
self.username = CONF.tobiko.tripleo.undercloud_ssh_username self.username = CONF.tobiko.tripleo.undercloud_ssh_username
self.key_filename = self.get_key_filenames()
@staticmethod @property
def get_key_filenames() -> typing.List[str]: def key_filename(self) -> typing.List[str]:
key_filenames: typing.List[str] = [] key_filenames: typing.List[str] = []
conf = tobiko.tobiko_config() conf = tobiko.tobiko_config()
key_filename = conf.tripleo.undercloud_ssh_key_filename key_filename = conf.tripleo.undercloud_ssh_key_filename