x/tobiko
Code Issues Proposed changes

Fix issues with upstream jobs

Browse Source 
setuptools version is pinned to 70.3.0 to resolve an issue
related to this ticket:
https://github.com/pypa/setuptools/issues/4483

pylint version is forced to >=3.3.0, where max-positional-arguments
functionality has been added and max-positional-arguments is set to 16:
https://github.com/pylint-dev/pylint/pull/9842

Changes in functional test test_stateless_sec_group_list_find because
sec group lists from a sec group can be ordered differently each time
a request is sent to obtain them.

Changed custom_mtu_size default value from 1350 to 1300 because some
tests started failing on some jobs with:
"Requested MTU is too big, maximum is 1314"

Change-Id: Ie92d9a2f4e0dd08aeadfd720bdf4963b532decf3
This commit is contained in:
Eduardo Olivares 2024-09-19 15:45:16 +02:00
parent 859ce180cb
commit 576859757d
5 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.pylintrc
View File

@ -845,6 +845,9 @@ ignored-parents=
# Maximum number of arguments for function / method. # Maximum number of arguments for function / method.
max-args=5 max-args=5
# Maximum number of positional arguments for function / method (default=5.)
max-positional-arguments = 16
# Maximum number of attributes for a class (see R0902). # Maximum number of attributes for a class (see R0902).
max-attributes=7 max-attributes=7

2
linters-requirements.txt
View File

@ -1,4 +1,4 @@
# pep8 and flake8 requirements # pep8 and flake8 requirements
pre-commit >= 2.16.0 # MIT pre-commit >= 2.16.0 # MIT
pylint>=2.5.3 # GPL2 pylint>=3.3.0 # GPL2

2
tobiko/openstack/neutron/config.py
View File

@ -46,7 +46,7 @@ OPTIONS = [
default=None, default=None,
help="List of nameservers IPv6 addresses"), help="List of nameservers IPv6 addresses"),
cfg.IntOpt('custom_mtu_size', cfg.IntOpt('custom_mtu_size',
default=1350, default=1300,
help=("Customized maximum transfer unit size\n" help=("Customized maximum transfer unit size\n"
"Notes:\n" "Notes:\n"
" - MTU values as small as 1000 has been seen " " - MTU values as small as 1000 has been seen "

12
tobiko/tests/functional/openstack/neutron/test_security_group.py
View File

@ -54,7 +54,17 @@ class StatelessSecurityGroupTest(testtools.TestCase):
f"{StatelessSecurityGroupFixture.__qualname__}-{i}") f"{StatelessSecurityGroupFixture.__qualname__}-{i}")
self.assertEqual(ssg_name, ssg_fixture.name) self.assertEqual(ssg_name, ssg_fixture.name)
ssg = neutron.list_security_groups(name=ssg_name).unique ssg = neutron.list_security_groups(name=ssg_name).unique
self.assertEqual(ssg, ssg_fixture.security_group) self.assertCountEqual(ssg.keys(),
ssg_fixture.security_group.keys())
for k in ssg.keys():
if k != 'security_group_rules':
self.assertEqual(ssg[k], ssg_fixture.security_group[k])
else:
# the elements from the lists ssg['security_group_rules']
# and ssg_fixture.security_group['security_group_rules']
# are equal, but they could be ordered in a different way
self.assertCountEqual(ssg[k],
ssg_fixture.security_group[k])
def test_stateless_sec_group_list_parameters(self): def test_stateless_sec_group_list_parameters(self):
for i, ssg_fixture in enumerate(self.ssg_fixture_list): for i, ssg_fixture in enumerate(self.ssg_fixture_list):

1
upper-constraints.txt
View File

@ -434,6 +434,7 @@ sentinels===1.0.0
seqdiag===3.0.0;python_version=='3.8' seqdiag===3.0.0;python_version=='3.8'
setproctitle===1.2.2 setproctitle===1.2.2
setuptools===60.9.3;python_version=='3.8' setuptools===60.9.3;python_version=='3.8'
setuptools===70.3.0;python_version>='3.9'
simplegeneric===0.8.1 simplegeneric===0.8.1
simplejson===3.17.6 simplejson===3.17.6
six===1.16.0 six===1.16.0