x
/
tobiko
Code Issues Proposed changes

Clean up multiple exception handling from stack traces 

Change-Id: I2ef7e46a7dc42f4047b24fccd736e6f6720ad8a0
This commit is contained in:
Federico Ressi 2020-09-28 09:44:02 +02:00
parent ac9b3a44f3
commit dd4340d36a
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tobiko/common/_exception.py
View File

@ -16,6 +16,7 @@ from __future__ import absolute_import
import contextlib
import collections
import sys
import typing # noqa
from oslo_log import log
import testtools
@ -130,17 +131,24 @@ def log_unhandled_exception(exc_type, exc_value, ex_tb):
@contextlib.contextmanager
def handle_multiple_exceptions(handle_exception=log_unhandled_exception):
exception: typing.Optional[typing.Tuple] = None
try:
yield
except testtools.MultipleExceptions as ex:
exc_infos = list_exc_infos()
if exc_infos:
exception = exc_infos[0]
for info in exc_infos[1:]:
handle_exception(*info)
reraise(*exc_infos[0])
try:
handle_exception(*info)
except Exception:
LOG.exception("Error handling multiple exceptions")
else:
LOG.debug(f"Empty MultipleExceptions: '{ex}'")
if exception is not None:
reraise(*exception)
def list_exc_infos(exc_info=None):
# pylint: disable=redefined-outer-name