Pylint cleanup (mostly unused or missing imports).

Change-Id: I31e1e8204062e3fd0a615940e837b52f930809a2

horizon/horizon/api/base.py

@@ -18,11 +18,8 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
-import functools
 import logging
 
-from django.utils.decorators import available_attrs
-
 from horizon import exceptions
 
 

horizon/horizon/api/keystone.py

@@ -22,7 +22,6 @@ import logging
 
 from django.conf import settings
 
-from keystoneclient import exceptions as keystone_exceptions
 from keystoneclient import service_catalog
 from keystoneclient.v2_0 import client as keystone_client
 from keystoneclient.v2_0 import tokens

horizon/horizon/api/nova.py

@@ -23,7 +23,6 @@ from __future__ import absolute_import
 
 import logging
 
-from django.contrib import messages
 from novaclient.v1_1 import client as nova_client
 from novaclient.v1_1 import security_group_rules as nova_rules
 from novaclient.v1_1.servers import REBOOT_HARD

horizon/horizon/base.py

@@ -23,7 +23,6 @@ the classes contained therein.
 """
 
 import copy
-import functools
 import inspect
 import logging
 
@@ -31,7 +30,7 @@ from django.conf import settings
 from django.conf.urls.defaults import patterns, url, include
 from django.contrib.auth.decorators import login_required
 from django.core.exceptions import ImproperlyConfigured
-from django.core.urlresolvers import reverse, RegexURLPattern
+from django.core.urlresolvers import reverse
 from django.utils.functional import SimpleLazyObject
 from django.utils.importlib import import_module
 from django.utils.module_loading import module_has_submodule

horizon/horizon/context_processors.py

@@ -24,7 +24,6 @@ Context processors used by Horizon.
 import logging
 
 from django.conf import settings
-from django.contrib import messages
 
 from horizon import api
 

horizon/horizon/decorators.py

@@ -22,9 +22,7 @@
 General-purpose decorators for use with Horizon.
 """
 import functools
-import logging
 
-from django import http
 from django.utils.decorators import available_attrs
 
 from horizon.exceptions import NotAuthorized

horizon/horizon/exceptions.py

@@ -22,6 +22,7 @@ import logging
 import sys
 
 from django.contrib import messages
+from django.utils.translation import ugettext as _
 from glance.common import exception as glanceclient
 from keystoneclient import exceptions as keystoneclient
 from novaclient import exceptions as novaclient

horizon/horizon/forms/base.py

@@ -20,16 +20,9 @@
 
 from datetime import date
 import logging
-import re
 
-from django import utils
-from django.conf import settings
-from django.contrib import messages
-from django.forms import *
-from django.forms import widgets
+from django import forms
 from django.utils import dates
-from django.utils import safestring
-from django.utils import formats
 
 from horizon import exceptions
 
@@ -37,7 +30,7 @@ from horizon import exceptions
 LOG = logging.getLogger(__name__)
 
 
-class SelfHandlingForm(Form):
+class SelfHandlingForm(forms.Form):
     """
     A base :class:`Form <django:django.forms.Form>` class which includes
     processing logic in its subclasses and handling errors raised during
@@ -53,7 +46,7 @@ class SelfHandlingForm(Form):
         This is used to determine whether this form should handle the
         input it is given or not.
     """
-    method = CharField(required=True, widget=HiddenInput)
+    method = forms.CharField(required=True, widget=forms.HiddenInput)
 
     def __init__(self, *args, **kwargs):
         initial = kwargs.pop('initial', {})
@@ -100,10 +93,10 @@ class SelfHandlingForm(Form):
             return form, None
 
 
-class DateForm(Form):
+class DateForm(forms.Form):
     """ A simple form for selecting a start date. """
-    month = ChoiceField(choices=dates.MONTHS.items())
-    year = ChoiceField()
+    month = forms.ChoiceField(choices=dates.MONTHS.items())
+    year = forms.ChoiceField()
 
     def __init__(self, *args, **kwargs):
         super(DateForm, self).__init__(*args, **kwargs)

horizon/horizon/middleware.py

@@ -23,8 +23,9 @@ Middleware provided and used by Horizon.
 
 import logging
 
-from django.contrib import messages
 from django import shortcuts
+from django.contrib import messages
+from django.utils.translation import ugettext as _
 
 from horizon import api
 from horizon import exceptions

horizon/horizon/site_urls.py

@@ -19,7 +19,7 @@
 #    under the License.
 
 from django.conf.urls.defaults import patterns, url, include
-from django.views.generic import TemplateView
+
 
 urlpatterns = patterns('horizon.views.auth',
     url(r'home/$', 'user_home', name='user_home'),

horizon/horizon/tables/actions.py

@@ -21,7 +21,7 @@ from django import shortcuts
 from django.forms.util import flatatt
 from django.contrib import messages
 from django.core import urlresolvers
-from django.utils.translation import string_concat
+from django.utils.translation import string_concat, ugettext as _
 
 from horizon import exceptions
 
@@ -358,7 +358,6 @@ class BatchAction(Action):
         return request.get_full_path()
 
     def handle(self, table, request, obj_ids):
-        tenant_id = request.user.tenant_id
         action_success = []
         action_failure = []
         action_not_allowed = []

horizon/horizon/templatetags/sizeformat.py

@@ -22,7 +22,6 @@
 Template tags for displaying sizes
 """
 
-import datetime
 from django import template
 from django.utils import translation
 from django.utils import formats

horizon/horizon/test.py

@@ -21,9 +21,7 @@
 import datetime
 
 from django import http
-from django import shortcuts
 from django import test as django_test
-from django import template as django_template
 from django.conf import settings
 from django.contrib.messages.storage import default_storage
 from django.test.client import RequestFactory

horizon/horizon/views/auth.py

@@ -21,7 +21,6 @@
 import logging
 
 from django import shortcuts
-from django.contrib import messages
 from django.utils.translation import ugettext as _
 
 import horizon