x
/
vmware-nsx
Code Issues Proposed changes

NSX|v+v3: Prevent adding default route to router 

Both NSX backend does not support adding a static route with destination
0.0.0.0/0.
The prefered way to change the default gw is to change the gw-ip of the
external subnet.

Change-Id: Ibb4f81a484de48f7ea65cb2bb6968e55eae087ad
This commit is contained in:
Adit Sarfaty 2017-12-25 09:07:39 +02:00
parent 97138d346a
commit 09784cc96b
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
vmware_nsx/plugins/common/plugin.py
View File

@ -320,6 +320,15 @@ class NsxPluginBase(db_base_plugin_v2.NeutronDbPluginV2,
return [self._make_subnet_dict(subnet_obj) for subnet_obj in
self._get_subnets_by_network(context.elevated(), network_id)]
def _validate_routes(self, context, router_id, routes):
super(NsxPluginBase, self)._validate_routes(
context, router_id, routes)
# do not allow adding a default route. NSX-v/v3 don't support it
for route in routes:
if route.get('destination') == '0.0.0.0/0':
msg = _("Cannot set a default route using static routes")
raise n_exc.BadRequest(resource='router', msg=msg)
# Register the callback
def _validate_network_has_subnet(resource, event, trigger, **kwargs):