From 1b7d7f1878058a40ae1a331b1be2743c3c9a36e1 Mon Sep 17 00:00:00 2001 From: ZhiQiang Fan Date: Thu, 23 Jan 2014 09:31:27 +0800 Subject: [PATCH] Enable hacking H233 rule H233: Check that all occurrences look like print functions, not print operator. Change-Id: I4600eb32e1a8ecba13fc252d7ef08681672a40a7 --- neutron/wsgi.py | 6 +++--- tox.ini | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/neutron/wsgi.py b/neutron/wsgi.py index 9e7964b458..bb94e10300 100644 --- a/neutron/wsgi.py +++ b/neutron/wsgi.py @@ -941,13 +941,13 @@ class Debug(Middleware): print(("*" * 40) + " REQUEST ENVIRON") for key, value in req.environ.items(): print(key, "=", value) - print + print() resp = req.get_response(self.application) print(("*" * 40) + " RESPONSE HEADERS") for (key, value) in resp.headers.iteritems(): print(key, "=", value) - print + print() resp.app_iter = self.print_generator(resp.app_iter) @@ -961,7 +961,7 @@ class Debug(Middleware): sys.stdout.write(part) sys.stdout.flush() yield part - print + print() class Router(object): diff --git a/tox.ini b/tox.ini index 22eed4b4ad..38f4bf4d9a 100644 --- a/tox.ini +++ b/tox.ini @@ -35,11 +35,10 @@ commands = {posargs} # E711/E712 comparison to False should be 'if cond is False:' or 'if not cond:' # query = query.filter(Component.disabled == False) # E125 continuation line does not distinguish itself from next logical line -# H233 Python 3.x incompatible use of print operator # H301 one import per line # H302 import only modules # TODO(marun) H404 multi line docstring should start with a summary -ignore = E711,E712,E125,H233,H301,H302,H404 +ignore = E711,E712,E125,H301,H302,H404 show-source = true builtins = _ exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,tools