x/vmware-nsx
Code Issues Proposed changes

Merge "Enhance exception translation to better handle NeutronExceptions"

Browse Source
This commit is contained in:
Jenkins 2013-09-15 23:44:34 +00:00 committed by Gerrit Code Review
commit 1bf5e729c9
3 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
neutron/api/v2/resource.py
View File

@ -147,9 +147,12 @@ def translate(translatable, locale):
was not translated was not translated
""" """
localize = gettextutils.get_localized_message localize = gettextutils.get_localized_message
if isinstance(translatable, Exception): if isinstance(translatable, exceptions.NeutronException):
translatable.message = localize(translatable.message, locale) translatable.msg = localize(translatable.msg, locale)
if isinstance(translatable, webob.exc.HTTPError): elif isinstance(translatable, webob.exc.HTTPError):
translatable.detail = localize(translatable.detail, locale) translatable.detail = localize(translatable.detail, locale)
return translatable elif isinstance(translatable, Exception):
translatable.message = localize(translatable.message, locale)
else:
return localize(translatable, locale) return localize(translatable, locale)
return translatable

4
neutron/common/exceptions.py
View File

@ -34,6 +34,7 @@ class NeutronException(Exception):
def __init__(self, **kwargs): def __init__(self, **kwargs):
try: try:
super(NeutronException, self).__init__(self.message % kwargs) super(NeutronException, self).__init__(self.message % kwargs)
self.msg = self.message % kwargs
except Exception: except Exception:
if _FATAL_EXCEPTION_FORMAT_ERRORS: if _FATAL_EXCEPTION_FORMAT_ERRORS:
raise raise
@ -41,6 +42,9 @@ class NeutronException(Exception):
# at least get the core message out if something happened # at least get the core message out if something happened
super(NeutronException, self).__init__(self.message) super(NeutronException, self).__init__(self.message)
def __unicode__(self):
return unicode(self.msg)
class BadRequest(NeutronException): class BadRequest(NeutronException):
message = _('Bad %(resource)s request: %(msg)s') message = _('Bad %(resource)s request: %(msg)s')

6
neutron/tests/unit/test_api_v2_resource.py
View File

@ -160,8 +160,7 @@ class ResourceTestCase(base.BaseTestCase):
self.assertEqual(wsgi.XMLDeserializer().deserialize(res.body), self.assertEqual(wsgi.XMLDeserializer().deserialize(res.body),
expected_res) expected_res)
@mock.patch('neutron.openstack.common.gettextutils.Message.data', @mock.patch('neutron.openstack.common.gettextutils.get_localized_message')
new_callable=mock.PropertyMock)
def test_unmapped_neutron_error_localized(self, mock_translation): def test_unmapped_neutron_error_localized(self, mock_translation):
gettextutils.install('blaa', lazy=True) gettextutils.install('blaa', lazy=True)
msg_translation = 'Translated error' msg_translation = 'Translated error'
@ -223,8 +222,7 @@ class ResourceTestCase(base.BaseTestCase):
self.assertEqual(wsgi.XMLDeserializer().deserialize(res.body), self.assertEqual(wsgi.XMLDeserializer().deserialize(res.body),
expected_res) expected_res)
@mock.patch('neutron.openstack.common.gettextutils.Message.data', @mock.patch('neutron.openstack.common.gettextutils.get_localized_message')
new_callable=mock.PropertyMock)
def test_mapped_neutron_error_localized(self, mock_translation): def test_mapped_neutron_error_localized(self, mock_translation):
gettextutils.install('blaa', lazy=True) gettextutils.install('blaa', lazy=True)
msg_translation = 'Translated error' msg_translation = 'Translated error'