x/vmware-nsx
Code Issues Proposed changes

Make test_nvp_sync.SyncLoopingCallTestCase reliable

Browse Source 
This patch removes the previous check that verified the mocked
looping call had an exact number of calls, and replaces it with a
simpler check that just verifies that the mock has been called.

As a consequence, this patch also shortens the test duration.

Closes-Bug: 1241969

Change-Id: Ia7bc66e1f2f631e46ddcbe0eacc1d5b2481274cb
This commit is contained in:
Salvatore Orlando 2013-10-19 02:06:37 -07:00
parent 71b5ccf8b2
commit 4e311e66de
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
neutron/tests/unit/nicira/test_nvp_sync.py
View File

@ -243,15 +243,15 @@ class SyncLoopingCallTestCase(base.BaseTestCase):
# Avoid runs of the synchronization process - just start # Avoid runs of the synchronization process - just start
# the looping call # the looping call
with mock.patch.object( with mock.patch.object(
sync.NvpSynchronizer, '_synchronize_state', sync.NvpSynchronizer, '_synchronize_state', return_value=0.01):
return_value=0.01):
synchronizer = sync.NvpSynchronizer(None, None, synchronizer = sync.NvpSynchronizer(None, None,
100, 0, 0) 100, 0, 0)
time.sleep(0.04999) time.sleep(0.03)
# stop looping call before asserting # stop looping call before asserting
synchronizer._sync_looping_call.stop() synchronizer._sync_looping_call.stop()
self.assertEqual( # Just verify the looping call has been called, trying
5, synchronizer._synchronize_state.call_count) # to assess the exact number of calls would be unreliable
self.assertTrue(synchronizer._synchronize_state.call_count)
class NvpSyncTestCase(base.BaseTestCase): class NvpSyncTestCase(base.BaseTestCase):