From 4f3d9343131c0283032e35450ed81e18c05e81b0 Mon Sep 17 00:00:00 2001 From: Gary Kotton Date: Mon, 8 May 2017 03:59:43 +0300 Subject: [PATCH] Address gate issues Change-Id: I91e324b3ab64fddc8ba2c63d971ae9c0d777ab81 --- .pylintrc | 21 +++++++++++++++++++++ test-requirements.txt | 2 +- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/.pylintrc b/.pylintrc index 83ffcfc21a..ae644cd99e 100644 --- a/.pylintrc +++ b/.pylintrc @@ -22,8 +22,10 @@ disable= no-member, no-method-argument, no-self-argument, + not-an-iterable, # "W" Warnings for stylistic problems or minor programming issues abstract-method, + abstract-class-instantiated, arguments-differ, attribute-defined-outside-init, bad-builtin, @@ -34,6 +36,7 @@ disable= expression-not-assigned, fixme, global-statement, + literal-comparison, no-init, non-parent-init-called, not-callable, @@ -48,26 +51,44 @@ disable= unused-argument, unused-import, unused-variable, + unsubscriptable-object, + useless-super-delegation, # TODO(dougwig) - disable nonstandard-exception while we have neutron_lib shims nonstandard-exception, # "C" Coding convention violations bad-continuation, + consider-iterating-dictionary, + consider-using-enumerate, invalid-name, + len-as-condition, + misplaced-comparison-constant, missing-docstring, + singleton-comparison, superfluous-parens, + ungrouped-imports, + wrong-import-order, + wrong-import-position, # "R" Refactor recommendations abstract-class-little-used, abstract-class-not-used, + consider-merging-isinstance, + consider-using-ternary, duplicate-code, interface-not-implemented, + no-else-return, no-self-use, + redefined-argument-from-local, + simplifiable-if-statement, too-few-public-methods, too-many-ancestors, too-many-arguments, + too-many-boolean-expressions, too-many-branches, + too-many-function-args, too-many-instance-attributes, too-many-lines, too-many-locals, + too-many-nested-blocks, too-many-public-methods, too-many-return-statements, too-many-statements, diff --git a/test-requirements.txt b/test-requirements.txt index 95d92e69f9..abc595af71 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -23,7 +23,7 @@ WebTest>=2.0 # MIT reno>=1.8.0 # Apache-2.0 bandit>=1.1.0 # Apache-2.0 tempest>=14.0.0 # Apache-2.0 -pylint==1.4.5 # GPLv2 +pylint==1.7.1 # GPLv2 python-openstackclient>=3.3.0 # Apache-2.0 requests-mock>=1.1 # Apache-2.0 pyshark>=0.3.7.2 # pyshark