Update patch set 6

Patch Set 6:

(7 comments)

Patch-set: 6
Reviewer: Gerrit User 261 <261@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 261 2021-09-14 05:40:54 +00:00 committed by Gerrit Code Review
parent 7bcd4723de
commit 56e3ca0d36
1 changed files with 123 additions and 0 deletions

View File

@ -0,0 +1,123 @@
{
"comments": [
{
"key": {
"uuid": "b77ac57b_f0d1de67",
"filename": "vmware_nsx/shell/admin/plugins/nsxp/resources/networks.py",
"patchSetId": 6
},
"lineNbr": 166,
"author": {
"id": 261
},
"writtenOn": "2021-09-14T05:40:54Z",
"side": 1,
"message": "nit: consider a more generic message as you\u0027re catching a generic exception\n\neg: \"Error while retrieving NSX metadata proxy %s: %s\", metaproxy, e",
"revId": "80c3ed7e54e8a67c6bd4be79c188acd73b194069",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "b170fb1d_6171d747",
"filename": "vmware_nsx/shell/admin/plugins/nsxp/resources/routers.py",
"patchSetId": 6
},
"lineNbr": 143,
"author": {
"id": 261
},
"writtenOn": "2021-09-14T05:40:54Z",
"side": 1,
"message": "this is a rather pedant comment, but exception can be more than just \u0027not found\u0027 so the error message below might be more generic. Something like:\n\n\"An error occurred while retrieving Tier0 gw router %s: %s\", tier0, e",
"revId": "80c3ed7e54e8a67c6bd4be79c188acd73b194069",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "4ccbba56_618eb95a",
"filename": "vmware_nsx/shell/admin/plugins/nsxp/resources/routers.py",
"patchSetId": 6
},
"lineNbr": 146,
"author": {
"id": 261
},
"writtenOn": "2021-09-14T05:40:54Z",
"side": 1,
"message": "another pedant nit... in some cases a tier0 might be misconfigured and not have an edge cluster path. (It\u0027s allowed, even though it makes little sense in production, and no sense at all for Openstack).\n\nYou might consider adding a check to verify tier0_edge_cluster has a value, but addressing this is not mandatory in my opinion",
"revId": "80c3ed7e54e8a67c6bd4be79c188acd73b194069",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "ab5db42c_ff4cdb31",
"filename": "vmware_nsx/shell/admin/plugins/nsxp/resources/routers.py",
"patchSetId": 6
},
"lineNbr": 152,
"author": {
"id": 261
},
"writtenOn": "2021-09-14T05:40:54Z",
"side": 1,
"message": "for troubleshooting / serviceability reasons it might be worth having a separate log statement if no neutron routers were found. This is unlikely to happen, but adding such a statement will not cost much",
"revId": "80c3ed7e54e8a67c6bd4be79c188acd73b194069",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "84d47bdf_3b34a958",
"filename": "vmware_nsx/shell/admin/plugins/nsxp/resources/routers.py",
"patchSetId": 6
},
"lineNbr": 160,
"author": {
"id": 261
},
"writtenOn": "2021-09-14T05:40:54Z",
"side": 1,
"message": "nit: just for terminology, you can consider rewriting the above as \"Failed to update T0 uplink for router %s: %s\"",
"revId": "80c3ed7e54e8a67c6bd4be79c188acd73b194069",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "98df30e4_8ebd5e85",
"filename": "vmware_nsx/shell/admin/plugins/nsxp/resources/routers.py",
"patchSetId": 6
},
"lineNbr": 168,
"author": {
"id": 261
},
"writtenOn": "2021-09-14T05:40:54Z",
"side": 1,
"message": "I think there is an interesting twist here.\nthere is an option for allowing Tier-1s to use a separate edge cluster path (edge_cluster). In this case the Tier-1 router would be already using its own edge cluster and should not be moved to a new cluster.\n\nI think before setting the edge cluster path we can check if:\n- the edge_cluster option is set, or\n- verify that the tier1\u0027s current edge cluster matches the \u0027old\u0027 T0\u0027s edge cluster",
"revId": "80c3ed7e54e8a67c6bd4be79c188acd73b194069",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "73df1d28_7ad08e71",
"filename": "vmware_nsx/shell/admin/plugins/nsxp/resources/routers.py",
"patchSetId": 6
},
"lineNbr": 178,
"author": {
"id": 261
},
"writtenOn": "2021-09-14T05:40:54Z",
"side": 1,
"message": "can we make the process easier by only picking external networks?",
"revId": "80c3ed7e54e8a67c6bd4be79c188acd73b194069",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}