x
/
vmware-nsx
Code Issues Proposed changes

NSX|P: Do not search for FW resources when not needed 

cleanup_router_fw_resources was called twice when updating the
GW firewall and no FWaaS ports were found.
This method should be called only once inside delete_router_gateway_policy
if a policy exists.

Change-Id: Ib947720daaff2b0112d580e1353c9bae0f3dce06
This commit is contained in:
asarfaty 2020-04-23 09:23:35 +02:00
parent 0d88f9b98b
commit 5a0fc99a30
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
vmware_nsx/services/fwaas/nsx_p/fwaas_callbacks_v2.py
View File

@ -372,7 +372,6 @@ class NsxpFwaasCallbacksV2(com_callbacks.NsxCommonv3FwaasCallbacksV2):
# TODO(asarfaty): Consider keeping the FW with default allow
# rule instead of deletion as it may be created again soon
self.delete_router_gateway_policy(router_id)
self.cleanup_router_fw_resources(router_id)
def create_or_update_router_gateway_policy(self, context, router_id,
router, fw_rules):