Browse Source

V2T migration: Validate there are no non-neutron networks on the nsx

Change-Id: Ib3ae04c48d6040db3ee7a5ddc2eb3e1c1bd50b01
changes/95/777795/1
asarfaty 5 months ago
committed by Adit Sarfaty
parent
commit
65b0b6a6da
  1. 27
      vmware_nsx/shell/admin/plugins/nsxv/resources/migration.py
  2. 95
      vmware_nsx/shell/admin/plugins/nsxv/resources/networks.py
  3. 86
      vmware_nsx/shell/admin/plugins/nsxv/resources/utils.py

27
vmware_nsx/shell/admin/plugins/nsxv/resources/migration.py

@ -16,6 +16,7 @@ import netaddr
from oslo_config import cfg
from oslo_log import log as logging
from oslo_serialization import jsonutils
from oslo_utils import uuidutils
from networking_l2gw.db.l2gateway import l2gateway_models
from neutron.services.qos import qos_plugin
@ -230,6 +231,32 @@ def validate_config_for_migration(resource, event, trigger, **kwargs):
"to router %s without a gateway", net_id,
router['id'])
# Look for orphaned neutron networks and non neutron backend networks
backend_networks = utils.get_networks()
missing_networks = utils.get_orphaned_networks(backend_networks)
for net in missing_networks:
n_errors = n_errors + 1
LOG.error("ERROR: NSX backend network %s:%s is missing from "
"neutron and is probably an orphaned. Please delete it.",
net.get('moref'), net.get('name'))
for net in backend_networks:
moref = net['moref']
name = net['name']
net_type = net['type']
if ((len(name) < 36 or not uuidutils.is_uuid_like(name)) and
net_type in ['DistributedVirtualPortgroup', 'VirtualWire']):
if (net_type == 'DistributedVirtualPortgroup' and
name.startswith('edge-')):
continue
if (name == 'DPortGroup' and net_type ==
'DistributedVirtualPortgroup'):
continue
n_errors = n_errors + 1
LOG.error("ERROR: NSX backend network %s:%s is not a neutron "
"network and cannot be migrated. Please delete it.",
moref, name)
# Octavia loadbalancers validation:
filters = {'device_owner': [nl_constants.DEVICE_OWNER_LOADBALANCERV2,
oct_const.DEVICE_OWNER_OCTAVIA]}

95
vmware_nsx/shell/admin/plugins/nsxv/resources/networks.py

@ -13,7 +13,6 @@
# under the License.
import re
import xml.etree.ElementTree as et
from neutron_lib.callbacks import registry
from neutron_lib import context
@ -29,19 +28,11 @@ from vmware_nsx.plugins.nsx_v.vshield.common import exceptions
from vmware_nsx.shell.admin.plugins.common import constants
from vmware_nsx.shell.admin.plugins.common import formatters
from vmware_nsx.shell.admin.plugins.common import utils as admin_utils
from vmware_nsx.shell.admin.plugins.nsxv.resources import utils as utils
from vmware_nsx.shell.admin.plugins.nsxv.resources import utils
from vmware_nsx.shell import resources as shell
LOG = logging.getLogger(__name__)
nsxv = utils.get_nsxv_client()
network_types = ['Network', 'VirtualWire', 'DistributedVirtualPortgroup']
PORTGROUP_PREFIX = 'dvportgroup'
def get_networks_from_backend():
nsxv = utils.get_nsxv_client()
so_list = nsxv.get_scoping_objects()
return et.fromstring(so_list)
def get_virtual_wires():
@ -54,26 +45,13 @@ def get_virtual_wires():
return vw_hash
def get_networks():
"""Create an array of all the backend networks and their data
"""
root = get_networks_from_backend()
networks = []
for obj in root.iter('object'):
if obj.find('objectTypeName').text in network_types:
networks.append({'type': obj.find('objectTypeName').text,
'moref': obj.find('objectId').text,
'name': obj.find('name').text})
return networks
def get_networks_name_map():
"""Create a dictionary mapping moref->backend name
"""
root = get_networks_from_backend()
root = utils.get_networks_from_backend()
networks = {}
for obj in root.iter('object'):
if obj.find('objectTypeName').text in network_types:
if obj.find('objectTypeName').text in utils.network_types:
networks[obj.find('objectId').text] = obj.find('name').text
return networks
@ -81,7 +59,8 @@ def get_networks_name_map():
@admin_utils.output_header
def neutron_list_networks(resource, event, trigger,
**kwargs):
LOG.info(formatters.output_formatter(constants.NETWORKS, get_networks(),
LOG.info(formatters.output_formatter(constants.NETWORKS,
utils.get_networks(),
['type', 'moref', 'name']))
@ -170,67 +149,11 @@ def list_missing_networks(resource, event, trigger, **kwargs):
def list_orphaned_networks(resource, event, trigger, **kwargs):
"""List the NSX networks which are missing the neutron DB
"""
admin_context = context.get_admin_context()
missing_networks = []
# get all neutron distributed routers in advanced
with utils.NsxVPluginWrapper() as plugin:
neutron_routers = plugin.get_routers(
admin_context, fields=['id', 'name', 'distributed'])
neutron_dist_routers = [rtr for rtr in neutron_routers
if rtr['distributed']]
# get the list of backend networks:
backend_networks = get_networks()
for net in backend_networks:
moref = net['moref']
backend_name = net['name']
# Decide if this is a neutron network by its name (which should always
# contain the net-id), and type
if (backend_name.startswith('edge-') or len(backend_name) < 36 or
net['type'] == 'Network'):
# This is not a neutron network
continue
if backend_name.startswith('int-') and net['type'] == 'VirtualWire':
# This is a PLR network. Check that the router exists
found = False
# compare the expected lswitch name by the dist router name & id
for rtr in neutron_dist_routers:
lswitch_name = ('int-' + rtr['name'] + rtr['id'])[:36]
if lswitch_name == backend_name:
found = True
break
# if the neutron router got renamed, this will not work.
# compare ids prefixes instead (might cause false positives)
for rtr in neutron_dist_routers:
if rtr['id'][:5] in backend_name:
LOG.info("Logical switch %s probably matches distributed "
"router %s", backend_name, rtr['id'])
found = True
break
if not found:
missing_networks.append(net)
continue
# get the list of neutron networks with this moref
neutron_networks = nsx_db.get_nsx_network_mapping_for_nsx_id(
admin_context.session, moref)
if not neutron_networks:
# no network found for this moref
missing_networks.append(net)
elif moref.startswith(PORTGROUP_PREFIX):
# This is a VLAN network. Also verify that the DVS Id matches
for entry in neutron_networks:
if (not entry['dvs_id'] or
backend_name.startswith(entry['dvs_id'])):
found = True
# this moref & dvs-id does not appear in the DB
if not found:
missing_networks.append(net)
backend_networks = utils.get_networks()
orphaned_networks = utils.get_orphaned_networks(backend_networks)
LOG.info(formatters.output_formatter(constants.ORPHANED_NETWORKS,
missing_networks,
orphaned_networks,
['type', 'moref', 'name']))
@ -399,7 +322,7 @@ def delete_backend_network(resource, event, trigger, **kwargs):
# like VM, the deleting may fail and through an exception
nsxv = utils.get_nsxv_client()
if moref.startswith(PORTGROUP_PREFIX):
if moref.startswith(utils.PORTGROUP_PREFIX):
# get the dvs id from the backend name:
dvs_id = get_dvs_id_from_backend_name(backend_name)
if not dvs_id:

86
vmware_nsx/shell/admin/plugins/nsxv/resources/utils.py

@ -13,6 +13,7 @@
# under the License.
import time
import xml.etree.ElementTree as et
import mock
@ -23,12 +24,15 @@ from neutron_lib import context as neutron_context
from neutron_lib.plugins import directory
from vmware_nsx.common import config
from vmware_nsx.db import db as nsx_db
from vmware_nsx.extensions import projectpluginmap
from vmware_nsx import plugin
from vmware_nsx.plugins.nsx_v.vshield import vcns
from vmware_nsx.shell.admin.plugins.common import utils as admin_utils
LOG = logging.getLogger(__name__)
network_types = ['Network', 'VirtualWire', 'DistributedVirtualPortgroup']
PORTGROUP_PREFIX = 'dvportgroup'
def get_nsxv_client():
@ -188,3 +192,85 @@ def get_edge_syslog_info(edge_id):
output += "\n" + server_address
return output
def get_networks_from_backend():
nsxv = get_nsxv_client()
so_list = nsxv.get_scoping_objects()
return et.fromstring(so_list)
def get_networks():
"""Create an array of all the backend networks and their data
"""
root = get_networks_from_backend()
networks = []
for obj in root.iter('object'):
if obj.find('objectTypeName').text in network_types:
networks.append({'type': obj.find('objectTypeName').text,
'moref': obj.find('objectId').text,
'name': obj.find('name').text})
return networks
def get_orphaned_networks(backend_networks):
"""List the NSX networks which are missing the neutron DB
"""
admin_context = neutron_context.get_admin_context()
missing_networks = []
# get all neutron distributed routers in advanced
with NsxVPluginWrapper() as plugin:
neutron_routers = plugin.get_routers(
admin_context, fields=['id', 'name', 'distributed'])
neutron_dist_routers = [rtr for rtr in neutron_routers
if rtr['distributed']]
# get the list of backend networks:
for net in backend_networks:
moref = net['moref']
backend_name = net['name']
# Decide if this is a neutron network by its name (which should always
# contain the net-id), and type
if (backend_name.startswith('edge-') or len(backend_name) < 36 or
net['type'] == 'Network'):
# This is not a neutron network
continue
if backend_name.startswith('int-') and net['type'] == 'VirtualWire':
# This is a PLR network. Check that the router exists
found = False
# compare the expected lswitch name by the dist router name & id
for rtr in neutron_dist_routers:
lswitch_name = ('int-' + rtr['name'] + rtr['id'])[:36]
if lswitch_name == backend_name:
found = True
break
# if the neutron router got renamed, this will not work.
# compare ids prefixes instead (might cause false positives)
for rtr in neutron_dist_routers:
if rtr['id'][:5] in backend_name:
LOG.info("Logical switch %s probably matches distributed "
"router %s", backend_name, rtr['id'])
found = True
break
if not found:
missing_networks.append(net)
continue
# get the list of neutron networks with this moref
neutron_networks = nsx_db.get_nsx_network_mapping_for_nsx_id(
admin_context.session, moref)
if not neutron_networks:
# no network found for this moref
missing_networks.append(net)
elif moref.startswith(PORTGROUP_PREFIX):
# This is a VLAN network. Also verify that the DVS Id matches
for entry in neutron_networks:
if (not entry['dvs_id'] or
backend_name.startswith(entry['dvs_id'])):
found = True
# this moref & dvs-id does not appear in the DB
if not found:
missing_networks.append(net)
return missing_networks
Loading…
Cancel
Save