From 7630ecb8f2908ff77747da514097b4495f07177a Mon Sep 17 00:00:00 2001 From: Michal Kelner Mishali Date: Mon, 13 Aug 2018 09:20:42 +0300 Subject: [PATCH] NSX|V3: Support new icmp codes and types This patch is to verify and fix support for NSX ver 2.4, which involves new icmp list that is more strict. Change-Id: I91ef1bdc8287ea85281c543353774d6e3cac5ac2 Signed-off-by: Michal Kelner Mishali --- vmware_nsx/tests/unit/extensions/test_securitygroup.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vmware_nsx/tests/unit/extensions/test_securitygroup.py b/vmware_nsx/tests/unit/extensions/test_securitygroup.py index d30e84324f..5c7c696f3b 100644 --- a/vmware_nsx/tests/unit/extensions/test_securitygroup.py +++ b/vmware_nsx/tests/unit/extensions/test_securitygroup.py @@ -69,8 +69,8 @@ class TestSecurityGroups(test_nsxv3.NsxV3PluginTestCaseMixin, # port_range_min (ICMP type) is greater than port_range_max # (ICMP code) in order to confirm min <= max port check is # not called for ICMP. - port_range_min = 5 - port_range_max = 1 + port_range_min = 14 + port_range_max = None keys = [('remote_ip_prefix', remote_ip_prefix), ('security_group_id', security_group_id), ('direction', direction), @@ -106,8 +106,8 @@ class TestSecurityGroupsNoDynamicCriteria(test_nsxv3.NsxV3PluginTestCaseMixin, # port_range_min (ICMP type) is greater than port_range_max # (ICMP code) in order to confirm min <= max port check is # not called for ICMP. - port_range_min = 5 - port_range_max = 1 + port_range_min = 14 + port_range_max = None keys = [('remote_ip_prefix', remote_ip_prefix), ('security_group_id', security_group_id), ('direction', direction),