From df38a492694c13b177c5d98a4cc85b4f195778c7 Mon Sep 17 00:00:00 2001 From: asarfaty Date: Thu, 23 Apr 2020 09:23:35 +0200 Subject: [PATCH] NSX|P: Do not search for FW resources when not needed cleanup_router_fw_resources was called twice when updating the GW firewall and no FWaaS ports were found. This method should be called only once inside delete_router_gateway_policy if a policy exists. Change-Id: Ib947720daaff2b0112d580e1353c9bae0f3dce06 --- vmware_nsx/services/fwaas/nsx_p/fwaas_callbacks_v2.py | 1 - 1 file changed, 1 deletion(-) diff --git a/vmware_nsx/services/fwaas/nsx_p/fwaas_callbacks_v2.py b/vmware_nsx/services/fwaas/nsx_p/fwaas_callbacks_v2.py index b4a7f9f603..7d4ad04009 100644 --- a/vmware_nsx/services/fwaas/nsx_p/fwaas_callbacks_v2.py +++ b/vmware_nsx/services/fwaas/nsx_p/fwaas_callbacks_v2.py @@ -372,7 +372,6 @@ class NsxpFwaasCallbacksV2(com_callbacks.NsxCommonv3FwaasCallbacksV2): # TODO(asarfaty): Consider keeping the FW with default allow # rule instead of deletion as it may be created again soon self.delete_router_gateway_policy(router_id) - self.cleanup_router_fw_resources(router_id) def create_or_update_router_gateway_policy(self, context, router_id, router, fw_rules):