x/vmware-nsx
Code Issues Proposed changes

Fix protocol value for SG IPV6 RA rule

Browse Source 
The ingress SG rule for RA has a wrong value for protocol
field.

Change-Id: I4d3bca4b758540cf857eb13d36ee18f8ebc28272
Closes-Bug: #1312392
This commit is contained in:
sridhargaddam
2014-04-25 01:21:01 +05:30
parent 6eb4c8a91b
commit 826f9f5342
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
neutron/db/securitygroups_rpc_base.py
View File

@@ -337,7 +337,7 @@ class SecurityGroupServerRpcCallbackMixin(object):
ra_rule = {'direction': 'ingress', ra_rule = {'direction': 'ingress',
'ethertype': q_const.IPv6, 'ethertype': q_const.IPv6,
'protocol': 'icmp', 'protocol': q_const.PROTO_NAME_ICMP_V6,
'source_ip_prefix': ra_ip, 'source_ip_prefix': ra_ip,
'source_port_range_min': q_const.ICMPV6_TYPE_RA} 'source_port_range_min': q_const.ICMPV6_TYPE_RA}
port['security_group_rules'].append(ra_rule) port['security_group_rules'].append(ra_rule)

12
neutron/tests/unit/test_security_groups_rpc.py
View File

@@ -356,7 +356,7 @@ class SGServerRpcCallBackMixinTestCase(test_sg.SecurityGroupDBTestCase):
'port_range_min': 23, 'port_range_min': 23,
'source_ip_prefix': fake_prefix}, 'source_ip_prefix': fake_prefix},
{'direction': 'ingress', {'direction': 'ingress',
'protocol': const.PROTO_NAME_ICMP, 'protocol': const.PROTO_NAME_ICMP_V6,
'ethertype': const.IPv6, 'ethertype': const.IPv6,
'source_ip_prefix': fake_gateway, 'source_ip_prefix': fake_gateway,
'source_port_range_min': const.ICMPV6_TYPE_RA}, 'source_port_range_min': const.ICMPV6_TYPE_RA},
@@ -420,7 +420,7 @@ class SGServerRpcCallBackMixinTestCase(test_sg.SecurityGroupDBTestCase):
'security_group_id': sg1_id, 'security_group_id': sg1_id,
'port_range_min': 22}, 'port_range_min': 22},
{'direction': 'ingress', {'direction': 'ingress',
'protocol': const.PROTO_NAME_ICMP, 'protocol': const.PROTO_NAME_ICMP_V6,
'ethertype': const.IPv6, 'ethertype': const.IPv6,
'source_ip_prefix': gateway_lla_ip, 'source_ip_prefix': gateway_lla_ip,
'source_port_range_min': const.ICMPV6_TYPE_RA}, 'source_port_range_min': const.ICMPV6_TYPE_RA},
@@ -496,7 +496,7 @@ class SGServerRpcCallBackMixinTestCase(test_sg.SecurityGroupDBTestCase):
'security_group_id': sg1_id, 'security_group_id': sg1_id,
'port_range_min': 22}, 'port_range_min': 22},
{'direction': 'ingress', {'direction': 'ingress',
'protocol': const.PROTO_NAME_ICMP, 'protocol': const.PROTO_NAME_ICMP_V6,
'ethertype': const.IPv6, 'ethertype': const.IPv6,
'source_ip_prefix': gateway_lla_ip, 'source_ip_prefix': gateway_lla_ip,
'source_port_range_min': const.ICMPV6_TYPE_RA}, 'source_port_range_min': const.ICMPV6_TYPE_RA},
@@ -555,7 +555,7 @@ class SGServerRpcCallBackMixinTestCase(test_sg.SecurityGroupDBTestCase):
'security_group_id': sg1_id, 'security_group_id': sg1_id,
'port_range_min': 22}, 'port_range_min': 22},
{'direction': 'ingress', {'direction': 'ingress',
'protocol': const.PROTO_NAME_ICMP, 'protocol': const.PROTO_NAME_ICMP_V6,
'ethertype': const.IPv6, 'ethertype': const.IPv6,
'source_ip_prefix': fake_gateway, 'source_ip_prefix': fake_gateway,
'source_port_range_min': const.ICMPV6_TYPE_RA}, 'source_port_range_min': const.ICMPV6_TYPE_RA},
@@ -666,7 +666,7 @@ class SGServerRpcCallBackMixinTestCase(test_sg.SecurityGroupDBTestCase):
'port_range_min': 23, 'port_range_min': 23,
'dest_ip_prefix': fake_prefix}, 'dest_ip_prefix': fake_prefix},
{'direction': 'ingress', {'direction': 'ingress',
'protocol': const.PROTO_NAME_ICMP, 'protocol': const.PROTO_NAME_ICMP_V6,
'ethertype': const.IPv6, 'ethertype': const.IPv6,
'source_ip_prefix': fake_gateway, 'source_ip_prefix': fake_gateway,
'source_port_range_min': const.ICMPV6_TYPE_RA}, 'source_port_range_min': const.ICMPV6_TYPE_RA},
@@ -734,7 +734,7 @@ class SGServerRpcCallBackMixinTestCase(test_sg.SecurityGroupDBTestCase):
'remote_group_id': sg2_id, 'remote_group_id': sg2_id,
'security_group_id': sg1_id}, 'security_group_id': sg1_id},
{'direction': 'ingress', {'direction': 'ingress',
'protocol': const.PROTO_NAME_ICMP, 'protocol': const.PROTO_NAME_ICMP_V6,
'ethertype': const.IPv6, 'ethertype': const.IPv6,
'source_ip_prefix': fake_gateway, 'source_ip_prefix': fake_gateway,
'source_port_range_min': const.ICMPV6_TYPE_RA}, 'source_port_range_min': const.ICMPV6_TYPE_RA},