The code did not consider an empty list among the cases
in which security groups are not supplied on port create.
Change-Id: I6e4ac3dee0d02c6c26977f8e2fee717587b8bfc5
Closes-Bug: #1405311
OVS crash/restart is unpredictable, so neutron-ovs-agent should be
robust enough under that situation. But currently ovs-agent doesn't
figure out this error status(only check ovs restart/normal status)
and still continue to apply subsequent operations(set br/add patch
port/...) till causing exceptions/crash. Add flag to fully represent
ovs status. Base on that, we can add proper fail-over code in method
rpc_loop, to treat ovs dead/restart gracefully to prevent agent
crashes while it is running.
Closes-bug: #1296202
Change-Id: Id058b7ddef2ed337627dc692d0418786ad14f4b4
Since XML support has been removed test cases in test_api_v2_resource
no longer need to specify req_format.
Change-Id: Ic6572abc3121535e19d21e9a34d70bb42b9782de
Related-Bug: #1380787
CiscoCfgAgent.hosting_devices_removed() contains an error in the
format string used to log errors:
LOG.error(_LE("Invalid payload format for received RPC message "
"`hosting_devices_removed`. Error is %{error}s. "
"Payload is %(payload)s"),
{'error': e, 'payload': payload})
"%{error}s" should be "%(error)s"
The existing version raises "ValueError: unsupported format character
'{' (0x7b)" when invoked.
(found via pylint)
Change-Id: Ic5e9db2a19aa7652cbbd1ee04d7e02914e8d0093
Closes-Bug: #1403304
ofctl_arg_supported contains a bad call to LOG.debug in an exception
path.
LOG.debug("...%s. Exception: %s", (full_args, e))
This throws "TypeError: not enough arguments for format string" and
should be:
LOG.debug("...%s. Exception: %s", full_args, e)
(Found via pylint)
Change-Id: Ib14666f60b16584f225b1e0c4fed82ef7e941aac
Closes-Bug: #1403296
delete_subnet in Ml2 plugin instead of using SELECT FOR
UPDATE deletes the IPAllocations that can be auto-deleted
straight away.
An exception is raised if there are ports that cannot be
autodeleted.
delete_network in ML2 plugin tries to delete all ports
and subnets before performing the network deletion.
No lock is needed here - if some other process modifies
the Port or Subnet table, adding new items, the network
deletion will fail because of a violation of a foreign
key contraint.
In that case the operation will be retried.
Change-Id: Ib4e9441a95d6c80b92a43d55fdeb18d7b51a1cf3
Closes-bug: #1332917
It should have been removed when migrating to oslo.utils when we dropped
timeutils module from our tree.
Change-Id: I4093a3c8faf3da5790ee31fdebec0b8ed70f84f3
This change add a functional test for l3-agent metadata proxy to
verify:
* iptables redirection from 169.254.169.254:80
* headers added by the neutron-ns-metadata-proxy
* proxy to the metadata_socket by the neutron-ns-metadata-proxy
Change-Id: I16f1269644a56d932426daa3a89dd5a8f747b314
Mellanox plugin was marked deprecated in Juno.
This commit actually removes the code for Kilo.
Mellanox recommends users to use mlnx or SR-IOV MD
DocImpact
Closes-Bug: #1386539
Change-Id: I7d109bf62f71b2996aef4e0002f447ca3439a5cf
Signed-off-by: Moshe Levi <moshele@mellanox.com>
As functional jobs take more time to finish than unit tests and also
there is a chance that test will hang due to system interaction, this
patch sets maximum execution time to 90 seconds per test.
Change-Id: Ib58a1b53ace178e1bf99150628fa5576b079e8bc
After splitting in neutron database was left a number of tables
that don't have any models. Test should be improved to skip these
tables from checking.
Closes-bug: #1401424
Partially-Implements: blueprint services-split
Change-Id: I201b4a310eb26a86765c8541fba6e2d42431cf2a
New policy code requires that CONF is already initialized when policy
checks are invoked. It means that no Neutron context objects should be
created before BaseTestCase.setUp() is called that will set
configuration, among other things.
Ideally, we would just make sure that all test cases invoke
super().setUp() as the very first line of any subclass setUp() methods.
But since some of test cases require prior setup (like mocking extension
manager) before proceeding to base class, we end up with magically
shuffling context instantiations to occur below super() calls.
Change-Id: Ib1039ea1ff9480ca57f9cb0c917469d0d2ad28b8
Closes-Bug: #1400301
This test checks that port-update fails with 409 return code when
port-security is turned off on a port which contains address-pairs.
The test had a typo ('security-groups' -> 'security-group') which would
have cause it to produce false-positive.
This change rewrites the test and eliminates the possibility of this
false-positive to occurs.
Change-Id: Ib54ad089872f28eb28a3d4d050ba0ee8fdc2bfe2
Closes-Bug: #1400725
Signed-off-by: Roey Chen <roeyc@vmware.com>
The option has been marked deprecated in IceHouse.
Please use AGENT.tunnel_types=gre instead.
DocImpact
Related-Bug: #1195374
Change-Id: Iea6159c5949a63a0b680818a3fd0928d470115bd
Gary Kotton