12314 Commits

Author SHA1 Message Date
inspurericzhang
fb3baeac73 fix misspelling 'configuration' of functions
Change-Id: I2038d9796c8f63e4fa6577d7bd9360cf97aa05c9
2018-08-15 16:16:11 +08:00
Adit Sarfaty
88cbf05d0e NSX|V3 update port binding for callbacks notifications
When updating a port, the original port used in notifications should
have the port binding fields, or else some services (like FWaaS)
might fail.

Change-Id: I3a0d66b2741504903c9df92fcdd8520765d73f9d
2018-08-15 07:21:56 +00:00
Adit Sarfaty
7efe183d04 NSX|V3 update port binding for callbacks notifications
When updating a port, the original port used in notifications should
have the port binding fields, or else some services (like FWaaS)
might fail.

Change-Id: I3a0d66b2741504903c9df92fcdd8520765d73f9d
2018-08-15 10:18:01 +03:00
Michal Kelner Mishali
3144d1a6b1 NSX|V3: Support new icmp codes and types
This patch is to verify and fix support for
NSX ver 2.4, which involves new icmp list that
is more strict.

Change-Id: I91ef1bdc8287ea85281c543353774d6e3cac5ac2
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
2018-08-15 05:45:33 +00:00
Michal Kelner Mishali
7630ecb8f2 NSX|V3: Support new icmp codes and types
This patch is to verify and fix support for
NSX ver 2.4, which involves new icmp list that
is more strict.

Change-Id: I91ef1bdc8287ea85281c543353774d6e3cac5ac2
Signed-off-by: Michal Kelner Mishali <mkelnermishal@vmware.com>
2018-08-15 05:45:22 +00:00
Adit Sarfaty
106f4b950e NSX|V3: Add VPNaaS driver tests
Change-Id: I7a09e81a5d8c44e07aea190e450a465761b21432
2018-08-13 14:19:48 +03:00
Zuul
1eae04097e Merge "NSX|V: Shorten the L2 bridge edge name" into stable/rocky 2018-08-13 06:24:41 +00:00
Adit Sarfaty
23bc1886aa NSX|V3: Make sure LB member is connected to the LB router
When adding a member to the LB pool, the member subnet should belong to the
same router as the LB vip (unless external)

Change-Id: Ia27e476662b900e246d9d34df826ee72533eb343
2018-08-12 16:41:18 +00:00
Zuul
906e8f74b1 Merge "NSX|V3: Prevent adding an external net as a router interface" 2018-08-12 14:32:18 +00:00
Adit Sarfaty
204173e5b2 NSX|V3: Prevent adding an external net as a router interface
Also customize the plugin unittests to remove the unsupported cases,
and create network as external only when needed.

Change-Id: Ia970642e0375e395319737e2735deea289fd6e8e
2018-08-12 12:01:50 +00:00
Zuul
d4f7b28084 Merge "NSX|V3: Make sure LB member is connected to the LB router" 2018-08-12 09:57:55 +00:00
Zuul
4350e7c206 Merge "Remove extra period from invalidInput messages" 2018-08-12 09:56:45 +00:00
Adit Sarfaty
7b5c1a7a10 NSX|V3: Make sure LB member is connected to the LB router
When adding a member to the LB pool, the member subnet should belong to the
same router as the LB vip (unless external)

Change-Id: Ia27e476662b900e246d9d34df826ee72533eb343
2018-08-12 07:55:37 +00:00
Adit Sarfaty
73a6e7f4f5 Remove extra period from invalidInput messages
The exception class adds another '.' at the end.

Change-Id: I77b6cdadab566ab552d6814bd6c887dfc9bad230
2018-08-12 07:55:22 +00:00
Adit Sarfaty
e4ef701471 NSX|V: Shorten the L2 bridge edge name
The NSX backend support max length of 40 characters, and the name of the
edge is not used anywhere other than when it is created, so this patch
shorten the name prefix

Change-Id: Iab67c2f7df6dc213beb932e4633e9ff04f7daf66
2018-08-12 07:55:07 +00:00
Adit Sarfaty
497af80785 NSX|V3: Prevent adding an external net as a router interface
Also customize the plugin unittests to remove the unsupported cases,
and create network as external only when needed.

Change-Id: Ia970642e0375e395319737e2735deea289fd6e8e
2018-08-12 07:54:46 +00:00
Zuul
1266bf0901 Merge "NSX|V3: Fix port binding update on new ports" 2018-08-12 06:27:49 +00:00
Adit Sarfaty
af2399bea7 NSX|V: Shorten the L2 bridge edge name
The NSX backend support max length of 40 characters, and the name of the
edge is not used anywhere other than when it is created, so this patch
shorten the name prefix

Change-Id: Iab67c2f7df6dc213beb932e4633e9ff04f7daf66
2018-08-12 04:58:51 +00:00
Adit Sarfaty
1468f9e9da NSX|V3: Fix port binding update on new ports
Move the update of the port binding in the create-port result to
be after the apply_funct which overide it

Change-Id: I87f9c929a0fc967c15d8331fba9be6f36dc66b05
2018-08-12 04:58:38 +00:00
Adit Sarfaty
93f34f4656 NSX|V3: Fix port binding update on new ports
Move the update of the port binding in the create-port result to
be after the apply_funct which overide it

Change-Id: I87f9c929a0fc967c15d8331fba9be6f36dc66b05
2018-08-12 04:52:56 +00:00
Zuul
2faef7b459 Merge "NSX|V3: New admin utility to show MP cluster managers IPs" 2018-08-09 07:54:05 +00:00
Adit Sarfaty
caa451920b NSX|V3: New admin utility to show MP cluster managers IPs
Usage:
nsxadmin -r cluster -o show

Output example:
NSX Cluster has 3 manager nodes:
10.192.210.183
10.192.210.184
10.192.210.185

Change-Id: I1a138c759c52e25481fdf34f1ed3d861470adf3e
2018-08-09 05:37:14 +00:00
Zuul
16c092ba3a Merge "NSX|V3: Block subnets with host routes and DHCP disabled" 2018-08-06 08:34:37 +00:00
Zuul
322d37b156 Merge "NSX|V3 Add port binding to the DB" 2018-08-03 22:28:32 +00:00
Zuul
58cf26ea89 Merge "NSX|V3 exclude multicast addresses from NSX IPAM" 2018-08-03 18:45:03 +00:00
Abhishek Raut
0e29a2c4b9 Tag the alembic migration revisions for Rocky
This allows the database to be upgraded with the command:
  neutron-db-manage upgrade rocky

Change-Id: Ibe09edc43864a474978801598deaa3c95c392958
2018-08-02 09:45:09 +03:00
Zuul
61599c7cb2 Merge "NSX|V+V3: Move FW section logging update to admin utility" 2018-08-02 00:08:53 +00:00
Zuul
9d382ea33a Merge "NSX|V3 refactor add router interface code" 2018-08-01 22:55:25 +00:00
Adit Sarfaty
567d3dcb95 NSX|V3: Block subnets with host routes and DHCP disabled
Do not allow to create or update a subnet with disabled DHCP and
host routes.
Since the NSX-V plugin already had this code, reusing the same code.

Change-Id: Iedc58c37cc5930e4269b6225f1c52ae911e31268
2018-08-01 11:04:12 +00:00
Zuul
5e5d708b38 Merge "NSX|V3: Ensure early router GW validations" 2018-08-01 09:57:48 +00:00
Adit Sarfaty
2d1ab4963b NSX|V3 Add port binding to the DB
The QoS service reads the ports from the DB as objects, and expects
to find the port vif type there.
In this patch, the default vif type is added to the port binding DB
for each new port.

Change-Id: Icda3cf7d232fc83fb56f1b1add18d6201b233cd8
2018-08-01 09:13:44 +00:00
Zuul
e21bf9a907 Merge "NSXv: Add SG rule description to NSX notes field" 2018-08-01 09:01:54 +00:00
Zuul
7c7268f02b Merge "Fix LBaaS statistics" 2018-08-01 05:35:26 +00:00
Kobi Samoray
1c5620ab41 NSXv: Add SG rule description to NSX notes field
Populate the description field from OpenStack SG rule in NSX rule's note
field.

Change-Id: Ife3eb3fb2a2b3178cfd2bb522251b54681290c3b
2018-08-01 04:40:51 +00:00
Adit Sarfaty
dac109662e NSX|V+V3: Move FW section logging update to admin utility
On the plugin init there is a side process going over all the security
group rules in the NSX DFW checking if their logging flag should be
updated according to the global configuration flag.
Since this is relevant only in case the global config flag
log_security_groups_allowed_traffic was updated by the user, which is very rare,
this patch removed it from the code, and replaced it with an admin utility
that can be used.
This will make the plugin initialization process quicker and prevent unnecessary
load on the NSX.

Change-Id: I233915e589b53ccb4b76a3ef3d24bb56c0459e92
2018-08-01 04:32:13 +00:00
Adit Sarfaty
04c0c6c74d NSX|V3 Add log message on netowrk creation/update with QoS
Change-Id: I01b434457d69cdce9150ba7a35e2afc5d5888312
2018-07-31 11:50:26 +00:00
Adit Sarfaty
ce482ab0bc Fix LBaaS statistics
The octavia integration broke the LBaaS statistics by not
returning it to the LBaaS plugin

Change-Id: I395f375ee51518e5790c4f3036b697e405a9611a
2018-07-31 11:30:41 +03:00
Zuul
1f52913baf Merge "Remove invalid config from local.conf sample" 2018-07-31 07:53:46 +00:00
Adit Sarfaty
ac7e6926ce NSX|V3: Ensure early router GW validations
When the router GW info is updated, the TZ are validated.
This patch moves the validations to be done before the neutron update
in order to make sure the neutron rotuer is not updated.

Change-Id: Icb5b33d148ec2a2cdb04c93437f0ae903ef68b24
2018-07-31 10:45:33 +03:00
Adit Sarfaty
2b101cd177 NSX|V3 exclude multicast addresses from NSX IPAM
The NSX ipam (ip-pools) does not support multicast addresses.
The IPAM driver should skip those subnets and fallback to the default
(neutron) ipam implementation.

Change-Id: If65ec19b267edb33088563db29ceee3b7d90a95e
2018-07-31 07:24:27 +00:00
Adit Sarfaty
fdc6b1a1a1 NSX|V3 refactor add router interface code
A small refactor to the add rotuer interface method in order to
fail in case of non-overlay interface without a gw, before updating
the neutron router.
This is done to avoid the router rollback, that in some cases can
be problematic.

Change-Id: I2f8093b9f750f02592ae47c24a64f4a8b0dcfc86
2018-07-31 07:23:42 +00:00
Zuul
a373703b17 Merge "NSX|V3: Skip icmp rule tempest test" 2018-07-31 07:21:48 +00:00
Zuul
0078918a0e Merge "NSX|V3: Update failed LB member status" 2018-07-31 06:06:58 +00:00
Zuul
fefd3051f4 Merge "Fix NSX-V QoS tests to use legal tenant ID" 2018-07-31 06:06:31 +00:00
Zuul
62d8f16cb4 Merge "NSX|V: Combine plugin & MD proxy unit tests" 2018-07-31 06:06:30 +00:00
Adit Sarfaty
b362190d18 Remove invalid config from local.conf sample
DEFAULT_EDGE_CLUSTER_UUID is not used by the NSX devstack anywhere

Change-Id: I79ac205e02c07adbe38211e5bbc2157b3553615a
2018-07-31 08:49:46 +03:00
Adit Sarfaty
868c56b511 NSX|V3: Skip icmp rule tempest test
Some NSX versions do not support the ICMP code&type in this test

Change-Id: I903cddb319531aea58ca0760bfd6dea727e32710
2018-07-31 08:14:25 +03:00
Adit Sarfaty
12dd11789f Fix NSX-V QoS tests to use legal tenant ID
Change-Id: I1f129762b2022c1bde4cbd4ff521ce029af6f3e4
2018-07-30 11:55:08 +00:00
Zuul
65dd9ddcaf Merge "NSX|V3 remove unused parameter from router port call" 2018-07-30 07:40:14 +00:00
Adit Sarfaty
6bc5845515 NSX|V: Combine plugin & MD proxy unit tests
Combining the NSXv plugin unit tests with the mdproxy unit
tests, by enabling the MD proxy, and overriding different
list commands to skip internal MD proxy objects.
This is done in order not to run each test twice, which
prolongs the unitests significantly.

Change-Id: I26073aaf9c8ee6445b900f122420620d2d25c78c
2018-07-30 09:42:57 +03:00