8786e547f9
Bug #1050545 This fixes the exceptions occurring in the virtual switch mode of the Cisco plugin for create/delete/update network operations. The exceptions were occurring on account of the recent changes in the OVS module to the get_vlan and get_vlans methods, which were still being invoked here. Test configuration has been changed to increase the code coverage to catch such issues in the future. All changes are limited to the Cisco plugin and related tests. Change-Id: Id18473f7a9a2a22217a59b4f8b1541b4918e07e7
321 lines
13 KiB
Python
321 lines
13 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
#
|
|
# Copyright 2012 Cisco Systems, Inc. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
# @author: Sumit Naiksatam, Cisco Systems, Inc.
|
|
# @author: Rohit Agarwalla, Cisco Systems, Inc.
|
|
|
|
from copy import deepcopy
|
|
import inspect
|
|
import logging
|
|
|
|
from quantum.manager import QuantumManager
|
|
from quantum.openstack.common import importutils
|
|
from quantum.plugins.cisco.common import cisco_constants as const
|
|
from quantum.plugins.cisco.common import cisco_credentials_v2 as cred
|
|
from quantum.plugins.cisco.db import network_db_v2 as cdb
|
|
from quantum.plugins.cisco import l2network_plugin_configuration as conf
|
|
from quantum.plugins.openvswitch import ovs_db_v2 as odb
|
|
from quantum import quantum_plugin_base_v2
|
|
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
class VirtualPhysicalSwitchModelV2(quantum_plugin_base_v2.QuantumPluginBaseV2):
|
|
"""
|
|
This implementation works with OVS and Nexus plugin for the
|
|
following topology:
|
|
One or more servers to a nexus switch.
|
|
"""
|
|
MANAGE_STATE = True
|
|
__native_bulk_support = True
|
|
supported_extension_aliases = []
|
|
_plugins = {}
|
|
_inventory = {}
|
|
_methods_to_delegate = ['get_network', 'get_networks',
|
|
'create_port', 'create_port_bulk', 'delete_port',
|
|
'update_port', 'get_port', 'get_ports',
|
|
'create_subnet', 'create_subnet_bulk',
|
|
'delete_subnet', 'update_subnet', 'get_subnet',
|
|
'get_subnets', ]
|
|
|
|
def __init__(self):
|
|
"""
|
|
Initialize the segmentation manager, check which device plugins are
|
|
configured, and load the inventories those device plugins for which the
|
|
inventory is configured
|
|
"""
|
|
cdb.initialize()
|
|
cred.Store.initialize()
|
|
for key in conf.PLUGINS[const.PLUGINS].keys():
|
|
plugin_obj = conf.PLUGINS[const.PLUGINS][key]
|
|
self._plugins[key] = importutils.import_object(plugin_obj)
|
|
LOG.debug("Loaded device plugin %s\n" %
|
|
conf.PLUGINS[const.PLUGINS][key])
|
|
if key in conf.PLUGINS[const.INVENTORY].keys():
|
|
inventory_obj = conf.PLUGINS[const.INVENTORY][key]
|
|
self._inventory[key] = importutils.import_object(inventory_obj)
|
|
LOG.debug("Loaded device inventory %s\n" %
|
|
conf.PLUGINS[const.INVENTORY][key])
|
|
|
|
if hasattr(self._plugins[const.VSWITCH_PLUGIN],
|
|
"supported_extension_aliases"):
|
|
self.supported_extension_aliases.extend(
|
|
self._plugins[const.VSWITCH_PLUGIN].
|
|
supported_extension_aliases)
|
|
|
|
LOG.debug("%s.%s init done" % (__name__, self.__class__.__name__))
|
|
|
|
def __getattribute__(self, name):
|
|
"""
|
|
This delegates the calls to the methods implemented only by the OVS
|
|
sub-plugin.
|
|
"""
|
|
super_getattr = super(VirtualPhysicalSwitchModelV2,
|
|
self).__getattribute__
|
|
methods = super_getattr('_methods_to_delegate')
|
|
|
|
if name in methods:
|
|
plugin = super_getattr('_plugins')[const.VSWITCH_PLUGIN]
|
|
return getattr(plugin, name)
|
|
|
|
try:
|
|
return super_getattr(name)
|
|
except AttributeError:
|
|
plugin = super_getattr('_plugins')[const.VSWITCH_PLUGIN]
|
|
return getattr(plugin, name)
|
|
|
|
def _func_name(self, offset=0):
|
|
"""Get the name of the calling function"""
|
|
frame_record = inspect.stack()[1 + offset]
|
|
func_name = frame_record[3]
|
|
return func_name
|
|
|
|
def _invoke_plugin_per_device(self, plugin_key, function_name, args):
|
|
"""
|
|
Invokes a device plugin's relevant functions (on the it's
|
|
inventory and plugin implementation) for completing this operation.
|
|
"""
|
|
if not plugin_key in self._plugins.keys():
|
|
LOG.info("No %s Plugin loaded" % plugin_key)
|
|
LOG.info("%s: %s with args %s ignored" %
|
|
(plugin_key, function_name, args))
|
|
return
|
|
device_params = self._invoke_inventory(plugin_key, function_name,
|
|
args)
|
|
device_ips = device_params[const.DEVICE_IP]
|
|
if not device_ips:
|
|
return [self._invoke_plugin(plugin_key, function_name, args,
|
|
device_params)]
|
|
else:
|
|
output = []
|
|
for device_ip in device_ips:
|
|
new_device_params = deepcopy(device_params)
|
|
new_device_params[const.DEVICE_IP] = device_ip
|
|
output.append(self._invoke_plugin(plugin_key, function_name,
|
|
args, new_device_params))
|
|
return output
|
|
|
|
def _invoke_inventory(self, plugin_key, function_name, args):
|
|
"""
|
|
Invokes the relevant function on a device plugin's
|
|
inventory for completing this operation.
|
|
"""
|
|
if not plugin_key in self._inventory.keys():
|
|
LOG.info("No %s inventory loaded" % plugin_key)
|
|
LOG.info("%s: %s with args %s ignored" %
|
|
(plugin_key, function_name, args))
|
|
return {const.DEVICE_IP: []}
|
|
else:
|
|
return getattr(self._inventory[plugin_key], function_name)(args)
|
|
|
|
def _invoke_plugin(self, plugin_key, function_name, args, kwargs):
|
|
"""
|
|
Invokes the relevant function on a device plugin's
|
|
implementation for completing this operation.
|
|
"""
|
|
func = getattr(self._plugins[plugin_key], function_name)
|
|
func_args_len = int(inspect.getargspec(func).args.__len__()) - 1
|
|
fargs, varargs, varkw, defaults = inspect.getargspec(func)
|
|
if args.__len__() > func_args_len:
|
|
func_args = args[:func_args_len]
|
|
extra_args = args[func_args_len:]
|
|
for dict_arg in extra_args:
|
|
for k, v in dict_arg.iteritems():
|
|
kwargs[k] = v
|
|
return func(*func_args, **kwargs)
|
|
else:
|
|
if (varkw == 'kwargs'):
|
|
return func(*args, **kwargs)
|
|
else:
|
|
return func(*args)
|
|
|
|
def _get_segmentation_id(self, network_id):
|
|
binding_seg_id = odb.get_network_binding(None, network_id)
|
|
return binding_seg_id.segmentation_id
|
|
|
|
def create_network(self, context, network):
|
|
"""
|
|
Perform this operation in the context of the configured device
|
|
plugins.
|
|
"""
|
|
LOG.debug("create_network() called\n")
|
|
try:
|
|
args = [context, network]
|
|
ovs_output = self._invoke_plugin_per_device(const.VSWITCH_PLUGIN,
|
|
self._func_name(),
|
|
args)
|
|
vlan_id = self._get_segmentation_id(ovs_output[0]['id'])
|
|
vlan_name = conf.VLAN_NAME_PREFIX + str(vlan_id)
|
|
vlan_ids = cdb.get_ovs_vlans()
|
|
vlanids = ''
|
|
for v_id in vlan_ids:
|
|
vlanids = str(v_id) + ',' + vlanids
|
|
vlanids = vlanids.strip(',')
|
|
args = [ovs_output[0]['tenant_id'], ovs_output[0]['name'],
|
|
ovs_output[0]['id'], vlan_name, vlan_id,
|
|
{'vlan_ids':vlanids}]
|
|
nexus_output = self._invoke_plugin_per_device(const.NEXUS_PLUGIN,
|
|
self._func_name(),
|
|
args)
|
|
return ovs_output[0]
|
|
except:
|
|
# TODO (Sumit): Check if we need to perform any rollback here
|
|
raise
|
|
|
|
def create_network_bulk(self, context, networks):
|
|
"""
|
|
Perform this operation in the context of the configured device
|
|
plugins.
|
|
"""
|
|
LOG.debug("create_network_bulk() called\n")
|
|
try:
|
|
args = [context, networks]
|
|
ovs_output = self._plugins[
|
|
const.VSWITCH_PLUGIN].create_network_bulk(context, networks)
|
|
vlan_ids = cdb.get_ovs_vlans()
|
|
vlanids = ''
|
|
for v_id in vlan_ids:
|
|
vlanids = str(v_id[0]) + ',' + vlanids
|
|
vlanids = vlanids.strip(',')
|
|
LOG.debug("ovs_output: %s\n " % ovs_output)
|
|
ovs_networks = ovs_output
|
|
for ovs_network in ovs_networks:
|
|
vlan_id = self._get_segmentation_id(ovs_network['id'])
|
|
vlan_name = conf.VLAN_NAME_PREFIX + str(vlan_id)
|
|
args = [ovs_network['tenant_id'], ovs_network['name'],
|
|
ovs_network['id'], vlan_name, vlan_id,
|
|
{'vlan_ids':vlanids}]
|
|
nexus_output = self._invoke_plugin_per_device(
|
|
const.NEXUS_PLUGIN, "create_network", args)
|
|
return ovs_output
|
|
except:
|
|
# TODO (Sumit): Check if we need to perform any rollback here
|
|
raise
|
|
|
|
def update_network(self, context, id, network):
|
|
"""
|
|
Perform this operation in the context of the configured device
|
|
plugins.
|
|
"""
|
|
LOG.debug("update_network() called\n")
|
|
args = [context, id, network]
|
|
ovs_output = self._invoke_plugin_per_device(const.VSWITCH_PLUGIN,
|
|
self._func_name(),
|
|
args)
|
|
vlan_id = self._get_segmentation_id(ovs_output[0]['id'])
|
|
vlan_ids = ','.join(str(vlan[0]) for vlan in cdb.get_ovs_vlans())
|
|
args = [ovs_output[0]['tenant_id'], id, {'vlan_id': vlan_id},
|
|
{'net_admin_state': ovs_output[0]['admin_state_up']},
|
|
{'vlan_ids': vlan_ids}]
|
|
nexus_output = self._invoke_plugin_per_device(const.NEXUS_PLUGIN,
|
|
self._func_name(),
|
|
args)
|
|
return ovs_output[0]
|
|
|
|
def delete_network(self, context, id):
|
|
"""
|
|
Perform this operation in the context of the configured device
|
|
plugins.
|
|
"""
|
|
try:
|
|
base_plugin_ref = QuantumManager.get_plugin()
|
|
n = base_plugin_ref.get_network(context, id)
|
|
tenant_id = n['tenant_id']
|
|
vlan_id = self._get_segmentation_id(id)
|
|
output = []
|
|
args = [tenant_id, id, {const.VLANID:vlan_id},
|
|
{const.CONTEXT:context},
|
|
{const.BASE_PLUGIN_REF:base_plugin_ref}]
|
|
nexus_output = self._invoke_plugin_per_device(const.NEXUS_PLUGIN,
|
|
self._func_name(),
|
|
args)
|
|
args = [context, id]
|
|
ovs_output = self._invoke_plugin_per_device(const.VSWITCH_PLUGIN,
|
|
self._func_name(),
|
|
args)
|
|
return ovs_output[0]
|
|
except:
|
|
raise
|
|
|
|
def get_network(self, context, id, fields=None):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|
|
|
|
def get_networks(self, context, filters=None, fields=None):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|
|
|
|
def create_port(self, context, port):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|
|
|
|
def get_port(self, context, id, fields=None):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|
|
|
|
def get_ports(self, context, filters=None, fields=None):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|
|
|
|
def update_port(self, context, id, port):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|
|
|
|
def delete_port(self, context, id, kwargs):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|
|
|
|
def create_subnet(self, context, subnet):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|
|
|
|
def update_subnet(self, context, id, subnet):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|
|
|
|
def get_subnet(self, context, id, fields=None):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|
|
|
|
def delete_subnet(self, context, id, kwargs):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|
|
|
|
def get_subnets(self, context, filters=None, fields=None):
|
|
"""For this model this method will be delegated to vswitch plugin"""
|
|
pass
|