
If there are multiple load balancers share the same LB service, LB service will be deleted if there is no virtual server attached to it. This patch fixes an load balancer deletion issue if LB service has already been deleted. Change-Id: I797c0bcbcaa90156577aa3b853c31ecb9bb96636
148 lines
6.3 KiB
Python
148 lines
6.3 KiB
Python
# Copyright 2017 VMware, Inc.
|
|
# All Rights Reserved
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
|
|
from neutron_lib.callbacks import events
|
|
from neutron_lib.callbacks import registry
|
|
from neutron_lib.callbacks import resources
|
|
from neutron_lib import exceptions as n_exc
|
|
from oslo_log import helpers as log_helpers
|
|
from oslo_log import log as logging
|
|
|
|
from vmware_nsx._i18n import _
|
|
from vmware_nsx.db import db as nsx_db
|
|
from vmware_nsx.services.lbaas import base_mgr
|
|
from vmware_nsx.services.lbaas import lb_const
|
|
from vmware_nsx.services.lbaas.nsx_v3 import lb_utils
|
|
from vmware_nsxlib.v3 import exceptions as nsxlib_exc
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
|
|
class EdgeLoadBalancerManager(base_mgr.Nsxv3LoadbalancerBaseManager):
|
|
@log_helpers.log_method_call
|
|
def __init__(self):
|
|
super(EdgeLoadBalancerManager, self).__init__()
|
|
registry.subscribe(
|
|
self._handle_subnet_gw_change,
|
|
resources.SUBNET, events.AFTER_UPDATE)
|
|
|
|
@log_helpers.log_method_call
|
|
def create(self, context, lb):
|
|
if lb_utils.validate_lb_subnet(context, self.core_plugin,
|
|
lb.vip_subnet_id):
|
|
self.lbv2_driver.load_balancer.successful_completion(context, lb)
|
|
else:
|
|
msg = _('Cannot create lb on subnet %(sub)s for '
|
|
'loadbalancer %(lb)s as it does not connect '
|
|
'to router') % {'sub': lb.vip_subnet_id,
|
|
'lb': lb.id}
|
|
raise n_exc.BadRequest(resource='lbaas-subnet', msg=msg)
|
|
|
|
@log_helpers.log_method_call
|
|
def update(self, context, old_lb, new_lb):
|
|
self.lbv2_driver.load_balancer.successful_completion(context, new_lb)
|
|
|
|
@log_helpers.log_method_call
|
|
def delete(self, context, lb):
|
|
service_client = self.core_plugin.nsxlib.load_balancer.service
|
|
lb_binding = nsx_db.get_nsx_lbaas_loadbalancer_binding(
|
|
context.session, lb.id)
|
|
if lb_binding:
|
|
lb_service_id = lb_binding['lb_service_id']
|
|
nsx_router_id = lb_binding['lb_router_id']
|
|
try:
|
|
lb_service = service_client.get(lb_service_id)
|
|
except nsxlib_exc.ManagerError:
|
|
LOG.warning("LB service %(lbs)s is not found",
|
|
{'lbs': lb_service_id})
|
|
else:
|
|
vs_list = lb_service.get('virtual_server_ids')
|
|
if not vs_list:
|
|
try:
|
|
service_client.delete(lb_service_id)
|
|
# If there is no lb service attached to the router,
|
|
# update the router advertise_lb_vip flag to false.
|
|
router_client = self.core_plugin.nsxlib.logical_router
|
|
router_client.update_advertisement(
|
|
nsx_router_id, advertise_lb_vip=False)
|
|
except nsxlib_exc.ManagerError:
|
|
self.lbv2_driver.load_balancer.failed_completion(
|
|
context, lb, delete=True)
|
|
msg = (_('Failed to delete lb service %(lbs)s from nsx'
|
|
) % {'lbs': lb_service_id})
|
|
raise n_exc.BadRequest(resource='lbaas-lb', msg=msg)
|
|
nsx_db.delete_nsx_lbaas_loadbalancer_binding(
|
|
context.session, lb.id)
|
|
self.lbv2_driver.load_balancer.successful_completion(
|
|
context, lb, delete=True)
|
|
|
|
@log_helpers.log_method_call
|
|
def refresh(self, context, lb):
|
|
# TODO(tongl): implememnt
|
|
pass
|
|
|
|
@log_helpers.log_method_call
|
|
def stats(self, context, lb):
|
|
# Since multiple LBaaS loadbalancer can share the same LB service,
|
|
# get the corresponding virtual servers' stats instead of LB service.
|
|
stats = {'active_connections': 0,
|
|
'bytes_in': 0,
|
|
'bytes_out': 0,
|
|
'total_connections': 0}
|
|
|
|
service_client = self.core_plugin.nsxlib.load_balancer.service
|
|
lb_binding = nsx_db.get_nsx_lbaas_loadbalancer_binding(
|
|
context.session, lb.id)
|
|
vs_list = self._get_lb_virtual_servers(context, lb)
|
|
if lb_binding:
|
|
lb_service_id = lb_binding.get('lb_service_id')
|
|
try:
|
|
rsp = service_client.get_stats(lb_service_id)
|
|
if rsp:
|
|
for vs in rsp['virtual_servers']:
|
|
# Skip the virtual server that doesn't belong
|
|
# to this loadbalancer
|
|
if vs['virtual_server_id'] not in vs_list:
|
|
continue
|
|
vs_stats = vs['statistics']
|
|
for stat in lb_const.LB_STATS_MAP:
|
|
lb_stat = lb_const.LB_STATS_MAP[stat]
|
|
stats[stat] += vs_stats[lb_stat]
|
|
|
|
except nsxlib_exc.ManagerError:
|
|
msg = _('Failed to retrieve stats from LB service '
|
|
'for loadbalancer %(lb)s') % {'lb': lb.id}
|
|
raise n_exc.BadRequest(resource='lbaas-lb', msg=msg)
|
|
return stats
|
|
|
|
def _get_lb_virtual_servers(self, context, lb):
|
|
# Get all virtual servers that belong to this loadbalancer
|
|
vs_list = []
|
|
for listener in lb.listeners:
|
|
vs_binding = nsx_db.get_nsx_lbaas_listener_binding(
|
|
context.session, lb.id, listener.id)
|
|
if vs_binding:
|
|
vs_list.append(vs_binding.get('lb_vs_id'))
|
|
return vs_list
|
|
|
|
def _handle_subnet_gw_change(self, *args, **kwargs):
|
|
# As the Edge appliance doesn't use DHCP, we should change the
|
|
# default gateway here when the subnet GW changes.
|
|
orig = kwargs['original_subnet']
|
|
updated = kwargs['subnet']
|
|
if orig['gateway_ip'] == updated['gateway_ip']:
|
|
return
|