This change wraps the command to generate a migration with code to update a file called HEAD. The HEAD file will contain the revision ID of the head of the migraton timeline. Additionally, check migrations has been altered to verify the contents of this file against the timeline head. This file helps the OpenStack gate detect potential migration branches without running alembic via git merge conflicts. Closes-Bug:1288427 Change-Id: If382c57baea061753d3f4fcd6faec1a31fbfb7ed
187 lines
6.7 KiB
Python
187 lines
6.7 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
#
|
|
# Copyright 2012 New Dream Network, LLC (DreamHost)
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
# @author Mark McClain (DreamHost)
|
|
|
|
import sys
|
|
|
|
import mock
|
|
|
|
from neutron.db import migration
|
|
from neutron.db.migration import cli
|
|
from neutron.tests import base
|
|
|
|
|
|
class TestDbMigration(base.BaseTestCase):
|
|
def test_should_run_plugin_in_list(self):
|
|
self.assertTrue(migration.should_run(['foo'], ['foo', 'bar']))
|
|
self.assertFalse(migration.should_run(['foo'], ['bar']))
|
|
|
|
def test_should_run_plugin_wildcard(self):
|
|
self.assertTrue(migration.should_run(['foo'], ['*']))
|
|
|
|
|
|
class TestCli(base.BaseTestCase):
|
|
def setUp(self):
|
|
super(TestCli, self).setUp()
|
|
self.do_alembic_cmd_p = mock.patch.object(cli, 'do_alembic_command')
|
|
self.do_alembic_cmd = self.do_alembic_cmd_p.start()
|
|
self.mock_alembic_err = mock.patch('alembic.util.err').start()
|
|
self.mock_alembic_err.side_effect = SystemExit
|
|
self.addCleanup(self.do_alembic_cmd_p.stop)
|
|
self.addCleanup(cli.CONF.reset)
|
|
|
|
def _main_test_helper(self, argv, func_name, exp_args=(), exp_kwargs={}):
|
|
with mock.patch.object(sys, 'argv', argv):
|
|
cli.main()
|
|
self.do_alembic_cmd.assert_has_calls(
|
|
[mock.call(mock.ANY, func_name, *exp_args, **exp_kwargs)]
|
|
)
|
|
|
|
def test_stamp(self):
|
|
self._main_test_helper(
|
|
['prog', 'stamp', 'foo'],
|
|
'stamp',
|
|
('foo',),
|
|
{'sql': False}
|
|
)
|
|
|
|
self._main_test_helper(
|
|
['prog', 'stamp', 'foo', '--sql'],
|
|
'stamp',
|
|
('foo',),
|
|
{'sql': True}
|
|
)
|
|
|
|
def test_current(self):
|
|
self._main_test_helper(['prog', 'current'], 'current')
|
|
|
|
def test_history(self):
|
|
self._main_test_helper(['prog', 'history'], 'history')
|
|
|
|
def test_check_migration(self):
|
|
with mock.patch.object(cli, 'validate_head_file') as validate:
|
|
self._main_test_helper(['prog', 'check_migration'], 'branches')
|
|
validate.assert_called_once_with(mock.ANY)
|
|
|
|
def test_database_sync_revision(self):
|
|
with mock.patch.object(cli, 'update_head_file') as update:
|
|
self._main_test_helper(
|
|
['prog', 'revision', '--autogenerate', '-m', 'message'],
|
|
'revision',
|
|
(),
|
|
{'message': 'message', 'sql': False, 'autogenerate': True}
|
|
)
|
|
update.assert_called_once_with(mock.ANY)
|
|
|
|
update.reset_mock()
|
|
self._main_test_helper(
|
|
['prog', 'revision', '--sql', '-m', 'message'],
|
|
'revision',
|
|
(),
|
|
{'message': 'message', 'sql': True, 'autogenerate': False}
|
|
)
|
|
update.assert_called_once_with(mock.ANY)
|
|
|
|
def test_upgrade(self):
|
|
self._main_test_helper(
|
|
['prog', 'upgrade', '--sql', 'head'],
|
|
'upgrade',
|
|
('head',),
|
|
{'sql': True}
|
|
)
|
|
|
|
self._main_test_helper(
|
|
['prog', 'upgrade', '--delta', '3'],
|
|
'upgrade',
|
|
('+3',),
|
|
{'sql': False}
|
|
)
|
|
|
|
def test_downgrade(self):
|
|
self._main_test_helper(
|
|
['prog', 'downgrade', '--sql', 'folsom'],
|
|
'downgrade',
|
|
('folsom',),
|
|
{'sql': True}
|
|
)
|
|
|
|
self._main_test_helper(
|
|
['prog', 'downgrade', '--delta', '2'],
|
|
'downgrade',
|
|
('-2',),
|
|
{'sql': False}
|
|
)
|
|
|
|
def _test_validate_head_file_helper(self, heads, file_content=None):
|
|
with mock.patch('alembic.script.ScriptDirectory.from_config') as fc:
|
|
fc.return_value.get_heads.return_value = heads
|
|
fc.return_value.get_current_head.return_value = heads[0]
|
|
with mock.patch('__builtin__.open') as mock_open:
|
|
mock_open.return_value.__enter__ = lambda s: s
|
|
mock_open.return_value.__exit__ = mock.Mock()
|
|
mock_open.return_value.read.return_value = file_content
|
|
|
|
with mock.patch('os.path.isfile') as is_file:
|
|
is_file.return_value = file_content is not None
|
|
|
|
if file_content in heads:
|
|
cli.validate_head_file(mock.sentinel.config)
|
|
else:
|
|
self.assertRaises(
|
|
SystemExit,
|
|
cli.validate_head_file,
|
|
mock.sentinel.config
|
|
)
|
|
self.mock_alembic_err.assert_called_once_with(mock.ANY)
|
|
fc.assert_called_once_with(mock.sentinel.config)
|
|
|
|
def test_validate_head_file_multiple_heads(self):
|
|
self._test_validate_head_file_helper(['a', 'b'])
|
|
|
|
def test_validate_head_file_missing_file(self):
|
|
self._test_validate_head_file_helper(['a'])
|
|
|
|
def test_validate_head_file_wrong_contents(self):
|
|
self._test_validate_head_file_helper(['a'], 'b')
|
|
|
|
def test_validate_head_success(self):
|
|
self._test_validate_head_file_helper(['a'], 'a')
|
|
|
|
def test_update_head_file_multiple_heads(self):
|
|
with mock.patch('alembic.script.ScriptDirectory.from_config') as fc:
|
|
fc.return_value.get_heads.return_value = ['a', 'b']
|
|
self.assertRaises(
|
|
SystemExit,
|
|
cli.update_head_file,
|
|
mock.sentinel.config
|
|
)
|
|
self.mock_alembic_err.assert_called_once_with(mock.ANY)
|
|
fc.assert_called_once_with(mock.sentinel.config)
|
|
|
|
def test_update_head_file_success(self):
|
|
with mock.patch('alembic.script.ScriptDirectory.from_config') as fc:
|
|
fc.return_value.get_heads.return_value = ['a']
|
|
fc.return_value.get_current_head.return_value = 'a'
|
|
with mock.patch('__builtin__.open') as mock_open:
|
|
mock_open.return_value.__enter__ = lambda s: s
|
|
mock_open.return_value.__exit__ = mock.Mock()
|
|
|
|
cli.update_head_file(mock.sentinel.config)
|
|
mock_open.write.called_once_with('a')
|
|
fc.assert_called_once_with(mock.sentinel.config)
|