x
/
vmware-nsxlib
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(3 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 32716 \u003c32716@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Danting Liu replied on the change"}
Attention: {"person_ident":"Gerrit User 25095 \u003c25095@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Danting Liu replied on the change"}
This commit is contained in:
Gerrit User 25095 2022-04-29 03:17:19 +00:00 committed by Gerrit Code Review
parent 8ebc98c4d8
commit 09c0fe85bb
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
baa50d5c883e7df1aebda69ac32ab4a6ab943b39 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "80cc191c_0bd75c29",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 6
},
"lineNbr": 373,
"author": {
"id": 25095
},
"writtenOn": "2022-04-29T03:17:19Z",
"side": 1,
"message": "Add comments for the difference between self._config_ca_file and self.ca_file.\nMaybe set self.ca_file as None first, and call select_cert() when using self.ca_file \u0026\u0026 self.ca_file\u003d\u003dNone",
"revId": "baa50d5c883e7df1aebda69ac32ab4a6ab943b39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e77891c7_239220a0",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 6
},
"lineNbr": 403,
"author": {
"id": 25095
},
"writtenOn": "2022-04-29T03:17:19Z",
"side": 1,
"message": "Any reason we should use this specific API? I mean is there any common API we can use, like the API used for health check.",
"revId": "baa50d5c883e7df1aebda69ac32ab4a6ab943b39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "138be347_6464661c",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 6
},
"lineNbr": 949,
"author": {
"id": 25095
},
"writtenOn": "2022-04-29T03:17:19Z",
"side": 1,
"message": "Is this the only place that provider will be invoked?",
"revId": "baa50d5c883e7df1aebda69ac32ab4a6ab943b39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}