x
/
vmware-nsxlib
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(3 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 32716 \u003c32716@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Tao Zou replied on the change"}
Attention: {"person_ident":"Gerrit User 25095 \u003c25095@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Tao Zou replied on the change"}
This commit is contained in:
Gerrit User 32716 2022-04-29 05:55:10 +00:00 committed by Gerrit Code Review
parent 09c0fe85bb
commit 1f95580be9
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
baa50d5c883e7df1aebda69ac32ab4a6ab943b39
View File

@ -17,6 +17,24 @@
"revId": "baa50d5c883e7df1aebda69ac32ab4a6ab943b39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5858e4d3_e529ae7d",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 6
},
"lineNbr": 373,
"author": {
"id": 32716
},
"writtenOn": "2022-04-29T05:55:10Z",
"side": 1,
"message": "if _config_ca_file is None or only one ca cert\n ca_file is the same as _config_ca_file\nelse \n after select_cert(), ca_file will point to the available ca cert.\n\nno matter what\u0027s the value of config\nafter select_cert(), ca_file points to the available ca cert if config has ca cert. \nconfig_ca_file keeps the value from config.",
"parentUuid": "80cc191c_0bd75c29",
"revId": "baa50d5c883e7df1aebda69ac32ab4a6ab943b39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -34,6 +52,24 @@
"revId": "baa50d5c883e7df1aebda69ac32ab4a6ab943b39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1e360d13_9850ddfc",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 6
},
"lineNbr": 403,
"author": {
"id": 32716
},
"writtenOn": "2022-04-29T05:55:10Z",
"side": 1,
"message": "no, the api could be removed and just use the https://url/, it doesn\u0027t matter which api using, just verify is ssl handshake could be done without error.",
"parentUuid": "e77891c7_239220a0",
"revId": "baa50d5c883e7df1aebda69ac32ab4a6ab943b39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -50,6 +86,24 @@
"message": "Is this the only place that provider will be invoked?",
"revId": "baa50d5c883e7df1aebda69ac32ab4a6ab943b39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "dd21187b_5c0ff1e0",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 6
},
"lineNbr": 949,
"author": {
"id": 32716
},
"writtenOn": "2022-04-29T05:55:10Z",
"side": 1,
"message": "yes.",
"parentUuid": "138be347_6464661c",
"revId": "baa50d5c883e7df1aebda69ac32ab4a6ab943b39",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}