x
/
vmware-nsxlib
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: -Code-Review

(1 comment)

Patch-set: 2
Label: Code-Review=0
This commit is contained in:
Gerrit User 24247 2022-05-18 18:48:36 +00:00 committed by Gerrit Code Review
parent 0d2cb7ec04
commit 2c1727621a
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
0f64b888ed28e55ed444125b31ddb4521e06a290
View File

@ -16,6 +16,23 @@
"message": "Hi Tao,\nI\u0027m not sure /tmp is a good location for a file that is expected to be present during lifelong run. As I understand, if this file is deleted, process will need to be restarted to select cert again. Not sure how big of a concern this should be (and it\u0027s more relevant for previous change than this one)\nOther than that LGTM (approving)",
"revId": "0f64b888ed28e55ed444125b31ddb4521e06a290",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "380949b4_aab681a0",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 2
},
"lineNbr": 456,
"author": {
"id": 24247
},
"writtenOn": "2022-05-18T18:48:36Z",
"side": 1,
"message": "I think this needs to be protected with try/except, otherwise exception will be thrown when cert is bad.",
"revId": "0f64b888ed28e55ed444125b31ddb4521e06a290",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}