From 4b654b13afbb04da0fa582ce752e45c95853f411 Mon Sep 17 00:00:00 2001 From: Anna Khmelnitsky Date: Mon, 27 Feb 2017 13:42:58 -0800 Subject: [PATCH] Fix FW rule dictionary Change-Id: Ia484d0429e104cd4c366df25ebe63b111920d4b4 --- vmware_nsxlib/v3/security.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/vmware_nsxlib/v3/security.py b/vmware_nsxlib/v3/security.py index b1174696..89dd5a0e 100644 --- a/vmware_nsxlib/v3/security.py +++ b/vmware_nsxlib/v3/security.py @@ -434,9 +434,11 @@ class NsxLibFirewallSection(utils.NsxLibApiBase): service = self._decide_service(sg_rule) name = sg_rule['id'] - return self.get_rule_dict(name, [source], - [destination], direction, - ip_protocol, [service], + return self.get_rule_dict(name, [source] if source else None, + [destination] if destination else None, + direction, + ip_protocol, + [service] if service else None, action, logged) def create_rules(self, context, section_id, nsgroup_id,