x
/
vmware-nsxlib
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
CC: Gerrit User 25095 <25095@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 25095 2022-04-28 09:13:27 +00:00 committed by Gerrit Code Review
parent 0190e440cc
commit 69473c9706
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
c6eacca1f09f46a90e046e39aa51e0e5586c3c6c Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "e215fe48_d7dc94d5",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 4
},
"lineNbr": 176,
"author": {
"id": 25095
},
"writtenOn": "2022-04-28T09:13:27Z",
"side": 1,
"message": "Are we sure each client will call nsxlib once, I mean class level parameters may have problems if there are several provider instances.",
"revId": "c6eacca1f09f46a90e046e39aa51e0e5586c3c6c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f37bbb20_99e995a1",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 4
},
"lineNbr": 229,
"author": {
"id": 25095
},
"writtenOn": "2022-04-28T09:13:27Z",
"side": 1,
"message": "So you want to verify ca_cert when setting it in session? How about having a separate function to get valid cert at the beginning, and use it in new_connection()",
"revId": "c6eacca1f09f46a90e046e39aa51e0e5586c3c6c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}