x
/
vmware-nsxlib
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+1

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 25095 <25095@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 32716 \u003c32716@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Danting Liu replied on the change"}
This commit is contained in:
Gerrit User 25095 2022-05-13 07:23:04 +00:00 committed by Gerrit Code Review
parent ca32718b7e
commit 90365fc95c
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
b3c90b440403fa34e766cb105fe75982868955ac Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "f02ac6a7_ca774abe",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 25095
},
"writtenOn": "2022-05-13T07:23:04Z",
"side": 1,
"message": "Please add UT",
"revId": "b3c90b440403fa34e766cb105fe75982868955ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "968963da_7c4fcbbc",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 1
},
"lineNbr": 431,
"author": {
"id": 25095
},
"writtenOn": "2022-05-13T07:23:04Z",
"side": 1,
"message": "Could you add more comments to explain the logic here, like we will separate self-signed cert and chained cert, and put chained certs in a file together.",
"revId": "b3c90b440403fa34e766cb105fe75982868955ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}