x
/
vmware-nsxlib
Code Issues Proposed changes

Deprecate unused dhcp_profile_uuid from config 

The dhcp_profile_uuid is a part of the nsxlib configuration but it is
never used.
Adding a deprecation warning for it, and stop adding it to the config class.

Change-Id: Ib36ba0c473d66d81a99d79c691548642da34982c
This commit is contained in:
Adit Sarfaty 2017-03-06 09:16:19 +02:00
parent 627964757b
commit 9e927a5b23
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
vmware_nsxlib/v3/config.py
View File

@ -13,6 +13,14 @@
# License for the specific language governing permissions and limitations
# under the License.
from oslo_log import log
from oslo_log import versionutils
from vmware_nsxlib._i18n import _LW
LOG = log.getLogger(__name__)
class NsxLibConfig(object):
"""Class holding all the configuration parameters used by the nsxlib code.
@ -61,8 +69,8 @@ class NsxLibConfig(object):
binding entries. These will be used if there are
no nameservers defined on the subnet.
:param dns_domain: Domain to use for building the hostnames.
:param dhcp_profile_uuid: The UUID of the NSX DHCP Profile that will be
used to enable native DHCP service.
:param dhcp_profile_uuid: Currently unused and deprecated.
Kept for backward compatibility.
"""
@ -105,7 +113,13 @@ class NsxLibConfig(object):
self.plugin_ver = plugin_ver
self.dns_nameservers = dns_nameservers or []
self.dns_domain = dns_domain
self.dhcp_profile_uuid = dhcp_profile_uuid
if dhcp_profile_uuid:
# this is deprecated, and never used.
versionutils.report_deprecated_feature(
LOG,
_LW('dhcp_profile_uuid is not used by the nsxlib, and will '
'be removed from its configuration in the future.'))
def _attribute_by_index(self, scalar_or_list, index):
if isinstance(scalar_or_list, list):