x
/
vmware-nsxlib
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(3 comments)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 25095 \u003c25095@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Danting Liu replied on the change"}
This commit is contained in:
Gerrit User 25095 2022-05-06 02:33:45 +00:00 committed by Gerrit Code Review
parent 448e3c9f24
commit e9c98bc9d7
1 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
9acf464506aaaa81e32b5aa05665e7f101c4b3e4 Normal file
View File

@ -0,0 +1,61 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "9f7806be_8f220546",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 7
},
"lineNbr": 397,
"author": {
"id": 25095
},
"writtenOn": "2022-05-06T02:33:45Z",
"side": 1,
"message": "ncp -\u003e client?",
"range": {
"startLine": 397,
"startChar": 17,
"endLine": 397,
"endChar": 20
},
"revId": "9acf464506aaaa81e32b5aa05665e7f101c4b3e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5dd4a68d_1bf7742e",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 7
},
"lineNbr": 411,
"author": {
"id": 25095
},
"writtenOn": "2022-05-06T02:33:45Z",
"side": 1,
"message": "If all certs verification fail, should we return the first one or do nothing?",
"revId": "9acf464506aaaa81e32b5aa05665e7f101c4b3e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "51238a4b_50f0898f",
"filename": "vmware_nsxlib/v3/cluster.py",
"patchSetId": 7
},
"lineNbr": 429,
"author": {
"id": 25095
},
"writtenOn": "2022-05-06T02:33:45Z",
"side": 1,
"message": "In which case we may fail to write ca file?",
"revId": "9acf464506aaaa81e32b5aa05665e7f101c4b3e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}