x/vmware-nsxlib
Code Issues Proposed changes

Update patch set 4

Browse Source 
Patch Set 4:

(6 comments)

Patch-set: 4
Reviewer: Gerrit User 20363 <20363@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 20363
2016-12-13 09:15:08 +00:00
committed by Gerrit Code Review
parent 809efb9b47
commit f937936e46
1 changed files with 114 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

114
ae891090192d00d13edd6607eadca9612072277a
View File

@@ -35,6 +35,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_9ae28d02",
"filename": "vmware_nsxlib/v3/exceptions.py",
"patchSetId": 4
},
"lineNbr": 66,
"author": {
"id": 20363
},
"writtenOn": "2016-12-13T09:15:08Z",
"side": 1,
"message": "No need for this None. Thanks",
"parentUuid": "1a6eadb0_0112a962",
"revId": "ae891090192d00d13edd6607eadca9612072277a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a71b18c_6f263fcf",
@@ -58,6 +76,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_3aba59e2",
"filename": "vmware_nsxlib/v3/nsx_constants.py",
"patchSetId": 4
},
"lineNbr": 106,
"author": {
"id": 20363
},
"writtenOn": "2016-12-13T09:15:08Z",
"side": 1,
"message": "Done",
"parentUuid": "3a71b18c_6f263fcf",
"range": {
"startLine": 106,
"startChar": 9,
"endLine": 106,
"endChar": 14
},
"revId": "ae891090192d00d13edd6607eadca9612072277a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_2509702d",
@@ -75,6 +117,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_5abf15d0",
"filename": "vmware_nsxlib/v3/nsx_constants.py",
"patchSetId": 4
},
"lineNbr": 107,
"author": {
"id": 20363
},
"writtenOn": "2016-12-13T09:15:08Z",
"side": 1,
"message": "Done",
"parentUuid": "1a6eadb0_2509702d",
"revId": "ae891090192d00d13edd6607eadca9612072277a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_e55db8ed",
@@ -92,6 +152,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_fadb8119",
"filename": "vmware_nsxlib/v3/resources.py",
"patchSetId": 4
},
"lineNbr": 587,
"author": {
"id": 20363
},
"writtenOn": "2016-12-13T09:15:08Z",
"side": 1,
"message": "Will do.",
"parentUuid": "1a6eadb0_e55db8ed",
"revId": "ae891090192d00d13edd6607eadca9612072277a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_45f82ce6",
@@ -109,6 +187,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_da3c0532",
"filename": "vmware_nsxlib/v3/resources.py",
"patchSetId": 4
},
"lineNbr": 600,
"author": {
"id": 20363
},
"writtenOn": "2016-12-13T09:15:08Z",
"side": 1,
"message": "No - the backend will fail and we will raise ManagerError, so I think it is good enough.",
"parentUuid": "1a6eadb0_45f82ce6",
"revId": "ae891090192d00d13edd6607eadca9612072277a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_85ac04ef",
@@ -125,6 +221,24 @@
"revId": "ae891090192d00d13edd6607eadca9612072277a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_3aeed98b",
"filename": "vmware_nsxlib/v3/resources.py",
"patchSetId": 4
},
"lineNbr": 630,
"author": {
"id": 20363
},
"writtenOn": "2016-12-13T09:15:08Z",
"side": 1,
"message": "Ok. I\u0027ll do it in a following patch",
"parentUuid": "1a6eadb0_85ac04ef",
"revId": "ae891090192d00d13edd6607eadca9612072277a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}