zuul
/
nodepool
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: I would prefer that you didn't merge this

(1 inline comment)

Same caveat I have on the other ones - tests needed - applies here. Also docstrings need to be kept up to date please.

Patch-set: 2
Reviewer: Gerrit User 4190 <4190@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 4190 2013-10-07 19:42:41 +00:00 committed by Gerrit Code Review
parent 02288631ea
commit 08c3574a56
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
5d2226089ec4a4c83fde779d8483a5de648029e9 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "AAAATH//750\u003d",
"filename": "nodepool/provider_manager.py",
"patchSetId": 2
},
"lineNbr": 311,
"author": {
"id": 4190
},
"writtenOn": "2013-10-07T19:42:41Z",
"side": 1,
"message": "Please document that additional **kwargs will be passed directly to Nova.",
"revId": "5d2226089ec4a4c83fde779d8483a5de648029e9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}