zuul
/
nodepool
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: (1 inline comment)



Patch-set: 2
Label: Code-Review=0
This commit is contained in:
Gerrit User 1 2013-10-10 21:49:36 +00:00 committed by Gerrit Code Review
parent 85b0954738
commit 0da1ce4ae7
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
5695884bb399672a18626c729f031228c162e844
View File

@ -16,6 +16,24 @@
"revId": "5695884bb399672a18626c729f031228c162e844",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAATH//tWs\u003d",
"filename": "nodepool/nodepool.py",
"patchSetId": 2
},
"lineNbr": 995,
"author": {
"id": 1
},
"writtenOn": "2013-10-10T21:49:36Z",
"side": 1,
"message": "Compare to launchNode below -- this means you can pass in a ProviderImage or a TargetImage and this method will correctly get the one it needs (ProviderImage). Otherwise, this would be duplicated in a couple of other methods (where it actually gets more complex because those methods don\u0027t care about ProviderImages otherwise).",
"parentUuid": "AAAATH//tXk\u003d",
"revId": "5695884bb399672a18626c729f031228c162e844",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}