From 25f26165eb68165c29f9e950dacf2d8c07e7c59d Mon Sep 17 00:00:00 2001 From: Tobias Henkel Date: Mon, 15 Oct 2018 14:20:52 +0200 Subject: [PATCH] Remove unneeded todo comment This removes a todo about request deferring. This is not valid at this point because we already locked the request and further are in a loop that must run fast. Change-Id: I2858a418fe0ed953e4a300c6d27fca10b65194ef --- nodepool/driver/__init__.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/nodepool/driver/__init__.py b/nodepool/driver/__init__.py index ba0281b16..d2ca3d71d 100644 --- a/nodepool/driver/__init__.py +++ b/nodepool/driver/__init__.py @@ -543,11 +543,6 @@ class NodeRequestHandler(NodeRequestHandlerNotifications, elif not self.hasProviderQuota(self.request.node_types): declined_reasons.append('it would exceed quota') - # TODO(tobiash): Maybe also calculate the quota prediction here and - # backoff for some seconds if the used quota would be exceeded? - # This way we could give another (free) provider the chance to take - # this request earlier. - if declined_reasons: self.log.debug("Declining node request %s because %s", self.request.id, ', '.join(declined_reasons))