zuul
/
nodepool
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+2

(2 comments)

Patch-set: 3
Reviewer: Gerrit User 7118 <7118@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 267f7b820c7e86b3bff079a204f7eb1d8cacd3be
Attention: {"person_ident":"Gerrit User 7118 \u003c7118@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_7118\u003e replied on the change"}
This commit is contained in:
Gerrit User 7118 2023-01-29 21:18:35 +00:00 committed by Gerrit Code Review
parent 41ca9594d3
commit 321521e6ba
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
80d83da73fb3d7980445edb8e187800fb3bd719b Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "60d3f411_175f450d",
"filename": "nodepool/nodeutils.py",
"patchSetId": 3
},
"lineNbr": 179,
"author": {
"id": 7118
},
"writtenOn": "2023-01-29T21:18:35Z",
"side": 1,
"message": "perhaps perf_counter() is a better fit for this call?",
"revId": "80d83da73fb3d7980445edb8e187800fb3bd719b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "aaeba982_b0d7bf14",
"filename": "nodepool/nodeutils.py",
"patchSetId": 3
},
"lineNbr": 183,
"author": {
"id": 7118
},
"writtenOn": "2023-01-29T21:18:35Z",
"side": 1,
"message": "I do get that the point is to specifically see the cost of a given call in context, but I wonder if this would be useful to have a key and send this into statsd for aggregate data too?",
"revId": "80d83da73fb3d7980445edb8e187800fb3bd719b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}