zuul
/
nodepool
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(3 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1 \u003c1@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"removed on reply"}
Attention: {"person_ident":"Gerrit User 4146 \u003c4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Someone else replied on a comment you posted"}
This commit is contained in:
Gerrit User 1 2024-03-07 19:46:00 +00:00 committed by Gerrit Code Review
parent aa482108be
commit 33404b592a
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
646b7f49279b89850aa95671f64ebbbf392fc1d2
View File

@ -139,6 +139,60 @@
"parentUuid": "a09af42f_79c9d4c3",
"revId": "646b7f49279b89850aa95671f64ebbbf392fc1d2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4a31d33e_1fb9527d",
"filename": "nodepool/builder.py",
"patchSetId": 1
},
"lineNbr": 712,
"author": {
"id": 1
},
"writtenOn": "2024-03-07T19:46:00Z",
"side": 1,
"message": "True, and distinct variable names probably would have been a good idea in retrospect. But I think this probably looks more confusing in review than in the code; the two classes handle images differently enough that it wasn\u0027t confusing when working on it. My line of thinking at the time was: They both have an image status, but each just has a different data format for the value.",
"parentUuid": "a09af42f_79c9d4c3",
"revId": "646b7f49279b89850aa95671f64ebbbf392fc1d2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "01657d80_8bca34d6",
"filename": "nodepool/builder.py",
"patchSetId": 1
},
"lineNbr": 712,
"author": {
"id": 1
},
"writtenOn": "2024-03-07T19:46:00Z",
"side": 1,
"message": "True, and distinct variable names probably would have been a good idea in retrospect. But I think this probably looks more confusing in review than in the code; the two classes handle images differently enough that it wasn\u0027t confusing when working on it. My line of thinking at the time was: They both have an image status, but each just has a different data format for the value.",
"parentUuid": "a09af42f_79c9d4c3",
"revId": "646b7f49279b89850aa95671f64ebbbf392fc1d2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1c607097_37ccfee6",
"filename": "nodepool/builder.py",
"patchSetId": 1
},
"lineNbr": 712,
"author": {
"id": 1
},
"writtenOn": "2024-03-07T19:46:00Z",
"side": 1,
"message": "True, and distinct variable names probably would have been a good idea in retrospect. But I think this probably looks more confusing in review than in the code; the two classes handle images differently enough that it wasn\u0027t confusing when working on it. My line of thinking at the time was: They both have an image status, but each just has a different data format for the value.",
"parentUuid": "a09af42f_79c9d4c3",
"revId": "646b7f49279b89850aa95671f64ebbbf392fc1d2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}